imgui: downgrade to opengl2 impl #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Creating a new rendering context may not be the best approach, it would be better to find the aspect of the game's context that messes with imgui's rendering and try resolving that instead. |
|
this commit tries an entirely different approach under the assumption that a system stuck with opengl 2.x will not be able to access any opengl 3.x+ attributes, implying that opengl 2 imgui should render fine. may be wrong but worth trying on real hardware. |
This reverts commit 0120c29.
so we know it runs on a real mac but it isnt rendering anything and i am out of ideas
|
Superseded by a9fd334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains a commit that replaces the OpenGL 3 implementation of Dear ImGui with its' OpenGL 2 counterpart. May fix rendering issues on old GPUs. Not tested beyond confirmation of it functioning on OpenGL 4.6 capable hardware.