Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/non member logic #81

Merged
merged 16 commits into from
Jan 18, 2022
Merged

Fix/non member logic #81

merged 16 commits into from
Jan 18, 2022

Conversation

seohyun-106
Copy link
Contributor

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

  • postBook api에 비회원 플로우를 반영했습니다

📌 변경 사항

  • response에 reviewId 추가
  • review create하는 부분 추가

Linked Issue

close #80

Copy link
Member

@geeneve geeneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤭 참 잘했어요 🤭

@@ -22,6 +22,7 @@ const postBookController = async (req: Request, res: Response) => {
try {
const resData = await bookService.postBookService(
req.user ? true : false,
req.user ? Number(req.user.id) : constant.ANONYMOUS_USER,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 SWAG 😎

@@ -39,6 +41,28 @@ const postBookController = async (req: Request, res: Response) => {
);
}

if (resData == constant.ANONYMOUS_USER) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 음..... 🤔 한번은 실수

);
}

if (resData == constant.VALUE_ALREADY_EXIST) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔ㅇ ㅓ라라??? 한번이 아니네 ... 흠 ㅋㅋ 🤔🤔

});

return {
isLogin: isLogin,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋ

});

return {
isLogin: isLogin,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잉?

@holmir97 holmir97 merged commit a065d27 into develop Jan 18, 2022
@holmir97 holmir97 deleted the fix/non-member-logic branch January 18, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ priority: high 우선순위 높음
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] 서재에 책 추가하기 비회원 플로우 적용
3 participants