Feat/review now #40
Merged
Feat/review now #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holmir97
requested review from
seohyun-106 and
geeneve
and removed request for
seohyun-106
geeneve
approved these changes
Jan 14, 2022
src/controller/review.ts
Outdated
| @@ -55,7 +57,59 @@ const postReviewBeforeController = async (req: Request, res: Response) => { | |||
| res, | |||
| returnCode.OK, | |||
| true, | |||
| "독서 중 등록 성공", | |||
| "독서단계이동 (전 -> 중)", | |||
There was a problem hiding this comment.
이게 임시저장으로 쓰이면 전 -> 중은 아닌게 아닌가요? 🧐
src/service/review.ts
Outdated
| }, | ||
| }); | ||
|
|
||
| // 2. 존재하지 않은 review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR check list
🌈 PR 요약
review now api 추가
📌 변경 사항
Linked Issue
close #28