[feat] Implement membership withdrawal logic #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeneve
approved these changes
Apr 23, 2022
| // library | ||
| import { keysToSnake, keysToCamel } from "../library/convertSnakeToCamel"; | ||
|
|
||
| export const userScan = schedule.scheduleJob("0 0 0 * * *", async () => { |
There was a problem hiding this comment.
0초 0분 0시 매일 매달 매년
매 = *
로 이해하시면 될 것 같습니다
src/scheduler/userScheduler.ts
Outdated
| // 삭제 예정 유저 | ||
| const deletedUsers = await User.find(keysToSnake({ isDeleted: true })); | ||
|
|
||
| deletedUsers.map(async (user) => { |
There was a problem hiding this comment.
이 용도로 활용할때는 map 대신에 foreach가 좋을 듯~
There was a problem hiding this comment.
반환값이 불필요하고, 속도가 foreach가 더 빠르다는 점에서 동근님의 의견이 맞는것 같슴다.
수정하겠습니다
seohyun-106
approved these changes
Apr 23, 2022
| // library | ||
| import { keysToSnake, keysToCamel } from "../library/convertSnakeToCamel"; | ||
|
|
||
| export const userScan = schedule.scheduleJob("0 0 0 * * *", async () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈 PR 요약 / Linked Issue
회원탈퇴 Api 추가
User Scan 스케줄러 추가
close #137
📌 변경 사항
회원탈퇴 Api 가 추가되었습니다.
매일 자정 작동하는 스케줄러를 추가하였습니다.
콘솔을 통해 스케줄러 동작을 로깅할 수 있습니다.
node-scheduler 모듈이 추가되었습니다.
✅ PR check list
1. 제목 양식 준수 확인
[feat] PR title
2. 테스트 코드 작동 스크린샷
npm run mocha✅ After merge check list
1. 릴리즈 노트 변경
릴리즈 노트 To Do에서 Done으로 옮기기
2. 브랜치 삭제