[refactor] Add configuration manager #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeneve
added
๐ refactor
holmir97
approved these changes
Mar 24, 2022
| }, | ||
|
|
||
| // jwt ๊ด๋ จ | ||
| jwt: { |
| @@ -12,7 +13,7 @@ app.use(express.urlencoded()); | |||
| app.use(express.json()); | |||
|
|
|||
| // Port Host | |||
| const PORT: number = parseInt(process.env.PORT as string, 10) || 3000 || 8080; | |||
| const PORT: number = config.port || 3000 || 8080; | |||
There was a problem hiding this comment.
์ถํ์ ํฌํธ๋ฒํธ๋ ์์ ์ด ํ์ํ๊ฒ ๋ค์!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ PR ์์ฝ / Linked Issue
close [refactor] Use a configuration managerย #132
๐ ๋ณ๊ฒฝ ์ฌํญ
src/config/index.ts)process.env์ ๊ฐ๋ค์ ๋ถ๋ฌ์ฃผ์์ต๋๋ค.process.env๋ฅผ ์ฌ์ฉํ๊ณ ์๋ ์ฝ๋๋ค์config๊ฐ์ฒด๋ฅผ ์ฌ์ฉํ๋ ๊ฒ์ผ๋ก ๋ณ๊ฒฝํด์ฃผ์์ต๋๋ค.โ PR check list
1. ์ ๋ชฉ ์์ ์ค์ ํ์ธ
[feat] PR title
2. ํ ์คํธ ์ฝ๋ ์๋ ์คํฌ๋ฆฐ์ท
npm run mochaโ After merge check list
1. ๋ฆด๋ฆฌ์ฆ ๋ ธํธ ๋ณ๊ฒฝ
๋ฆด๋ฆฌ์ฆ ๋ ธํธ To Do์์ Done์ผ๋ก ์ฎ๊ธฐ๊ธฐ
2. ๋ธ๋์น ์ญ์