Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Modify Book find query #125

Merged
merged 2 commits into from
Mar 5, 2022
Merged

[fix] Modify Book find query #125

merged 2 commits into from
Mar 5, 2022

Conversation

holmir97
Copy link
Member

@holmir97 holmir97 commented Mar 5, 2022

๐ŸŒˆ PR ์š”์•ฝ / Linked Issue

๋…์„œ ์ค‘ ๋‹จ๊ณ„์—์„œ ์ž˜๋ชป๋œ book ์ •๋ณด๊ฐ€ response ๋˜๋Š” ๊ฒƒ์„ ์ˆ˜์ •

image

close #122

๐Ÿ“Œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

find ์ฟผ๋ฆฌ ์‚ฌ์šฉ ์‹œ ๋งจ ์ฒซ๋ฒˆ์งธ ๋„ํ๋จผํŠธ์— ์—‘์„ธ์Šค ๋˜๋Š” ๊ฒƒ์€ ์•„๋‹Œ์ง€ ํ™•์ธํ•  ๊ฒƒ!

โœ… PR check list

1. ์ œ๋ชฉ ์–‘์‹ ์ค€์ˆ˜ ํ™•์ธ

[feat] PR title

2. ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘๋™ ์Šคํฌ๋ฆฐ์ƒท

npm run mocha

โœ… After merge check list

1. ๋ฆด๋ฆฌ์ฆˆ ๋…ธํŠธ ๋ณ€๊ฒฝ

๋ฆด๋ฆฌ์ฆˆ ๋…ธํŠธ To Do์—์„œ Done์œผ๋กœ ์˜ฎ๊ธฐ๊ธฐ

2. ๋ธŒ๋žœ์น˜ ์‚ญ์ œ

@holmir97 holmir97 added ๐Ÿ”จ fix ์˜ค์ž‘๋™ ์ฝ”๋“œ ๋ฐ”๋กœ์žก๊ธฐ 1๏ธโƒฃ priority: high ์šฐ์„ ์ˆœ์œ„ ๋†’์Œ labels Mar 5, 2022
@holmir97 holmir97 added this to the v2.0.1 milestone Mar 5, 2022
@holmir97 holmir97 requested review from seohyun-106 and geeneve March 5, 2022 16:28
@holmir97 holmir97 self-assigned this Mar 5, 2022
@holmir97 holmir97 merged commit 8916df8 into develop Mar 5, 2022
@geeneve geeneve deleted the fix/book-find-query branch April 18, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ priority: high ์šฐ์„ ์ˆœ์œ„ ๋†’์Œ ๐Ÿ”จ fix ์˜ค์ž‘๋™ ์ฝ”๋“œ ๋ฐ”๋กœ์žก๊ธฐ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Access to wrong book data
2 participants