Refactor/switch database from postgreSQL to MongoDB #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seohyun-106
approved these changes
Feb 20, 2022
geeneve
approved these changes
Feb 20, 2022
src/interface/IBook.ts
Outdated
| export interface IBook { | ||
| _id: mongoose.Schema.Types.ObjectId; | ||
| isbn: Number; | ||
| isbn_sub: Number; |
There was a problem hiding this comment.
- not null이 아닌 칼럼에 ? 붙인다고 했던 것 같음!! (여기 아닌가..)
- O2 코드랑 다른게 여기는 대문자 Number고 O2는 소문자 number인데 차이가 있는건지 궁금해요
There was a problem hiding this comment.
- 스키마에 사용되는 인터페이스이기 때문에 여기선 ? 를 사용하지 않습니다! 추후에 DTO를 선언할때는 필요해요!
- 몽고디비는 Number 대문자 데이터 형식을 사용하기 때문에 스키마 선언시에는 Number로, 그 외에 DTO나 interface에서는 타입스크립트에 맞춰 number를 사용하는게 맞습니다, 이 코드에서는 제가 전부 Number를 쓰는 실수를 범했네요! 수정하겠습니다
src/models/User.ts
Outdated
| required: false, | ||
| }, | ||
| // 이메일 인증번호 | ||
| emailCode: { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR check list
🌈 PR 요약
postgreSQL 과 시퀄라이즈 제거
mongoDB, mongoCompass 설치
📌 변경 사항
테스팅을 위해 라우팅 부분을 주석하였습니다.
추가 설치 모듈
npm install mongoose
npm install mongoose-validator
npm install @types/mongoose
Linked Issue
close #102