Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove slack webhook message from jwt middlewares #104

Merged
merged 1 commit into from
Feb 20, 2022
Merged

fix: remove slack webhook message from jwt middlewares #104

merged 1 commit into from
Feb 20, 2022

Conversation

holmir97
Copy link
Member

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

JWT 토큰 에러메시지를 더이상 slack webhook에서 확인하지 않음

Linked Issue

close #101

@holmir97 holmir97 added 🔨 fix 오작동 코드 바로잡기 3️⃣ priority: low 우선순위 낮음 labels Feb 19, 2022
@holmir97 holmir97 self-assigned this Feb 19, 2022
seohyun-106
seohyun-106 approved these changes Feb 20, 2022
View reviewed changes
Copy link
Contributor

@seohyun-106 seohyun-106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 웹훅은 Wls이 되었네요 .. 슬랙이 안울렸으면 ..
그나저나 커밋 메세지 죽이네요 .. 간G ..

geeneve
geeneve approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@geeneve geeneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니당

@holmir97 holmir97 merged commit f889326 into develop Feb 20, 2022
@holmir97 holmir97 deleted the fix/slack-webhook-message branch February 20, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geeneve geeneve geeneve approved these changes

@seohyun-106 seohyun-106 seohyun-106 approved these changes

Assignees

@holmir97 holmir97

Labels
3️⃣ priority: low 우선순위 낮음 🔨 fix 오작동 코드 바로잡기
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] delete some slack-webhook messages
3 participants
@holmir97 @seohyun-106 @geeneve