Make app minimal requirement to Android 4.4 #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
added
the
Area-CodeHealth
TranceLove
force-pushed
the
feature/3189
branch
from
1ec84f4 to
b6965d5
Compare
VishnuSanal
previously approved these changes
Jan 7, 2023
EmmanuelMess
previously approved these changes
Jan 9, 2023
|
Probably should keep three android versions for tests, maybe kitkat, (something near) 5 and P? |
|
@EmmanuelMess If I'm to choose I shall choose 4.4, 8.0 and 11. |
- Robolectric Test against Android 4.4, 8.0 and 11.0 - Add GrantPermissionRule to unit tests that involve MainActivity, to grant MANAGE_EXTERNAL_STORAGE before starting
TranceLove
dismissed stale reviews from EmmanuelMess and VishnuSanal
via
bf147c8
VishalNehra
approved these changes
Jan 29, 2023
TranceLove
added a commit
that referenced
this pull request
Feb 2, 2023
Follow-up fix for #3692. - Migrate tests that are still testing on JELLY_BEAN - Update submodules Android version requirement to 4.4 too
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think it's about time to put this through... also for #3318 and #2988 to proceed, be it within the 4.x cycle.
Not removing the pre-4.4 logic within the code for now - can do on your call.
Issue tracker
Fixes #3189
Automatic tests
Manual tests
On Galaxy Nexus emulator running Android 4.3, Amaze no longer installs. But on Galaxy Nexus emulator running Android 4.4, Amaze still installs and runs.
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck