Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wildcard imports failing CI build with unit tests #3022

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Fix wildcard imports failing CI build with unit tests #3022

merged 1 commit into from
Nov 14, 2021

Conversation

TranceLove
Copy link
Collaborator

Description

Without this, compiler will be unable to distinguish between android.os.Build.VERSION_CODES.R and com.amaze.filemanager.R.

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@TranceLove TranceLove added Issue-Task (low) This isn't a bug, but should be dealt with. Area-CICD Issues related to CI/CD. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Test Related to tests (Robolectric, Espresso, JUnit) labels Nov 14, 2021
@TranceLove TranceLove added the Issue-Bug Related unexpected behavior or something worth investigating. label Nov 14, 2021
EmmanuelMess
EmmanuelMess previously approved these changes Nov 14, 2021
View reviewed changes
@TranceLove TranceLove mentioned this pull request Nov 14, 2021
Open
3 tasks
@EmmanuelMess
Copy link
Member

EmmanuelMess commented Nov 14, 2021 •
edited
Loading

I've seen a few this!! added in a few PRs, shouldn't those be replaced by something like assertNotNull(x); x.let {}? (Let because the lambda this sometimes hides an already existing this)

@TranceLove
Fix wildcard imports failing CI build with unit tests
6f13fda 
Without this, compiler will be unable to distinguish between android.os.Build.VERSION_CODES.R and com.amaze.filemanager.R.
@VishalNehra VishalNehra added this to the v3.7 milestone Nov 14, 2021
@VishalNehra VishalNehra merged commit 64d9f9d into release/3.7 Nov 14, 2021
@EmmanuelMess EmmanuelMess deleted the bugfix/r-imports branch December 25, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VishalNehra VishalNehra VishalNehra approved these changes

@EmmanuelMess EmmanuelMess EmmanuelMess approved these changes

Assignees
No one assigned
Labels
Area-CICD Issues related to CI/CD. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Test Related to tests (Robolectric, Espresso, JUnit) Issue-Bug Related unexpected behavior or something worth investigating. Issue-Task (low) This isn't a bug, but should be dealt with.
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
3 participants
@TranceLove @EmmanuelMess @VishalNehra