Fix value for legacy_listing_summary #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
added
Issue-Bug
VishalNehra
previously approved these changes
Jun 11, 2021
app/src/main/res/values/strings.xml
Outdated
| @@ -696,7 +696,7 @@ | |||
| <string name="clear_open_file_summary">Clears selected default file opening apps</string> | |||
| <string name="ftp_readonly">Read-only access</string> | |||
| <string name="legacy_listing_title">Use legacy listing for root</string> | |||
| <string name="legacy_listing_summary">If enabled, uses stat for listing, else uses ls</string> | |||
| <string name="legacy_listing_summary">If enabled, uses old method (ls) for listing files, else uses stat (new method)</string> | |||
There was a problem hiding this comment.
Old method and new method is kinda redundant. Plus the ls and stat is something user wouldn't care. We should minimise text here.
Say 'If enabled uses legacy listing method, else uses new method'
There was a problem hiding this comment.
I'll then say If enabled, uses legacy method to list files.
Its previous string value contradicts its behaviour - Amaze will use old method (ls) to list files when preference PreferenceConstants.PREFERENCE_ROOT_LEGACY_LISTING is true, while the translation string reads contradictory meaning.
TranceLove
force-pushed
the
bugfix/legacy_listing_summary-explanation
branch
from
7686362 to
29e2103
Compare
VishalNehra
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous string value for
legacy_listing_summaryin string.xml contradicts its behaviour - Amaze will use old method (ls) to list files when preference PreferenceConstants.PREFERENCE_ROOT_LEGACY_LISTING is true, while the translation string reads contradictory meaning.Manual tests
Done
Device: Fairphone 3
OS: LineageOS 16.0 (9.0)
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck