Add SAF permission grant routine for FTP server first run #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
added
Issue-Bug
EmmanuelMess
reviewed
Jun 8, 2021
| or Intent.FLAG_GRANT_READ_URI_PERMISSION | ||
| ) == PackageManager.PERMISSION_DENIED | ||
| ) { | ||
| mainActivity.accent.run { |
There was a problem hiding this comment.
Please at least put this function in a named constants so that this is more readable.
|
Working fine for me. |
VishalNehra
previously approved these changes
Jun 8, 2021
VishalNehra
previously approved these changes
Jun 9, 2021
Fixes #2592. - Refactored FtpServerFragment to allow different ActivityResultLauncher instances of different callbacks to be created in same code - Added routine to prompt user to grant access to device's internal storage (default FTP server shared folder) at SAF level
VishalNehra
approved these changes
Jun 10, 2021
3 tasks
TranceLove
added a commit
that referenced
this pull request
Jun 14, 2021
Continuation of #2598, fixes #2626. Saves the selected folder returned from ACTION_OPEN_DOCUMENT_TREE Intent. Additionally, fixed the detection of whether the FTP shared folder is within the internal storage, so ACTION_OPEN_DOCUMENT_TREE will also be triggered for user to select the shared folder in content:// URI.
TranceLove
added a commit
that referenced
this pull request
Jun 15, 2021
Continuation of #2598, fixes #2626. Saves the selected folder returned from ACTION_OPEN_DOCUMENT_TREE Intent. Additionally, fixed the detection of whether the FTP shared folder is within the internal storage, so ACTION_OPEN_DOCUMENT_TREE will also be triggered for user to select the shared folder in content:// URI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue tracker
Fixes #2592
Manual tests
Done
Device: LG Nexus 5x
OS: AOSPExtended 6.7 (9.0)
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck