SMB version of MainActivityHelper.checkFolder() #2229

TranceLove · 2021-01-19T09:56:58Z

PR Info

Issue tracker

Fixes will automatically close the related issue

Fixes #2189

Release

Addresses release/3.6

Test cases

Covered

Manual testing

Done

If yes,

Device: Fairphone 3
OS: LineageOS 16.0 (9.0)

Build tasks success

Successfully running following tasks on local

./gradlew assembledebug
./gradlew spotlessCheck

Additional Info

When copying from local to SMB, SMB URL was seen passed into MainActivityHelper.checkFolder(), causing the exception. Created a SMB version of the method to fix this.

app/src/main/java/com/amaze/filemanager/asynchronous/asynctasks/PrepareCopyTask.java

app/src/main/java/com/amaze/filemanager/utils/SmbUtil.java

app/src/main/java/com/amaze/filemanager/asynchronous/asynctasks/PrepareCopyTask.java

VishalNehra · 2021-01-19T22:07:19Z

I can't seem to figure out why the reported crash has path as java.io.FileNotFoundException: smb:/workgroup with a single forward slash 🤔

TranceLove · 2021-01-20T10:11:12Z

I can't seem to figure out why the reported crash has path as java.io.FileNotFoundException: smb:/workgroup with a single forward slash

PrepareCopyTask called this, that the SMB URI passed into the checkFolder method. Yeap, don't know why...

VishalNehra · 2021-01-27T21:15:19Z

Issue explanation (write below this line)

Trying to copy file to smb with the above changeset

Exception

User Action: UI Error
Request: Application crash
Version: 3.6.0
OS: Linux Android 10 - 29
Device: OnePlus6T
Model: ONEPLUS A6010
Product: OnePlus6T

Crash log

android.os.NetworkOnMainThreadException
	at android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1565)
	at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:116)
	at java.net.SocketOutputStream.write(SocketOutputStream.java:161)
	at jcifs.smb.SmbTransportImpl.doSend(SmbTransportImpl.java:910)
	at jcifs.util.transport.Transport.doSend(Transport.java:276)
	at jcifs.util.transport.Transport.sendrecv(Transport.java:215)
	at jcifs.smb.SmbTransportImpl.sendrecv(SmbTransportImpl.java:1021)
	at jcifs.smb.SmbTransportImpl.send(SmbTransportImpl.java:1539)
	at jcifs.smb.SmbSessionImpl.send(SmbSessionImpl.java:409)
	at jcifs.smb.SmbTreeImpl.send(SmbTreeImpl.java:472)
	at jcifs.smb.SmbTreeConnection.send0(SmbTreeConnection.java:404)
	at jcifs.smb.SmbTreeConnection.send(SmbTreeConnection.java:318)
	at jcifs.smb.SmbTreeConnection.send(SmbTreeConnection.java:298)
	at jcifs.smb.SmbTreeHandleImpl.send(SmbTreeHandleImpl.java:130)
	at jcifs.smb.SmbTreeHandleImpl.send(SmbTreeHandleImpl.java:117)
	at jcifs.smb.SmbFile.withOpen(SmbFile.java:1741)
	at jcifs.smb.SmbFile.withOpen(SmbFile.java:1710)
	at jcifs.smb.SmbFile.withOpen(SmbFile.java:1704)
	at jcifs.smb.SmbFile.queryPath(SmbFile.java:770)
	at jcifs.smb.SmbFile.exists(SmbFile.java:851)
	at com.amaze.filemanager.utils.SmbUtil.checkFolder(SmbUtil.java:122)
	at com.amaze.filemanager.utils.MainActivityHelper.checkFolder(MainActivityHelper.java:413)
	at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.finishCopying(PrepareCopyTask.java:329)
	at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.onEndDialog(PrepareCopyTask.java:279)
	at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.onEndDialog(PrepareCopyTask.java:272)
	at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.onPostExecute(PrepareCopyTask.java:186)
	at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.onPostExecute(PrepareCopyTask.java:64)
	at android.os.AsyncTask.finish(AsyncTask.java:755)
	at android.os.AsyncTask.access$900(AsyncTask.java:192)
	at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:772)
	at android.os.Handler.dispatchMessage(Handler.java:107)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7643)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:516)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)

Fixes TeamAmaze#2189.

app/src/main/java/com/amaze/filemanager/filesystem/FolderState.kt

VishalNehra · 2021-02-13T11:46:32Z

@TranceLove can you please fix the conflict here

VishalNehra · 2021-02-13T20:48:43Z

Sadly I'm still getting the exception log, so doesn't fix the issue still.
Though I can notice there's a leading / before smb:// now, if that helps to find the issue here.

2021-02-14 02:16:19.112 31870-31870/com.amaze.filemanager.debug W/System.err: java.io.FileNotFoundException: /smb:/vishalnehra:Vishal%[email protected]/vishalnehra/Downloads/2020-07-02_14.07 (1)/DummyFile: open failed: ENOENT (No such file or directory)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at libcore.io.IoBridge.open(IoBridge.java:496)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at java.io.FileOutputStream.<init>(FileOutputStream.java:235)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.amaze.filemanager.filesystem.FileUtil.isWritable(FileUtil.java:754)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.amaze.filemanager.utils.MainActivityHelper.checkFolder(MainActivityHelper.java:435)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.amaze.filemanager.utils.MainActivityHelper.checkFolder(MainActivityHelper.java:414)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.finishCopying(PrepareCopyTask.java:331)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.onEndDialog(PrepareCopyTask.java:281)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.onEndDialog(PrepareCopyTask.java:274)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.onPostExecute(PrepareCopyTask.java:188)
2021-02-14 02:16:19.115 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.amaze.filemanager.asynchronous.asynctasks.PrepareCopyTask.onPostExecute(PrepareCopyTask.java:66)
2021-02-14 02:16:19.116 31870-31870/com.amaze.filemanager.debug W/System.err:     at android.os.AsyncTask.finish(AsyncTask.java:755)
2021-02-14 02:16:19.116 31870-31870/com.amaze.filemanager.debug W/System.err:     at android.os.AsyncTask.access$900(AsyncTask.java:192)
2021-02-14 02:16:19.116 31870-31870/com.amaze.filemanager.debug W/System.err:     at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:772)
2021-02-14 02:16:19.116 31870-31870/com.amaze.filemanager.debug W/System.err:     at android.os.Handler.dispatchMessage(Handler.java:107)
2021-02-14 02:16:19.116 31870-31870/com.amaze.filemanager.debug W/System.err:     at android.os.Looper.loop(Looper.java:214)
2021-02-14 02:16:19.116 31870-31870/com.amaze.filemanager.debug W/System.err:     at android.app.ActivityThread.main(ActivityThread.java:7643)
2021-02-14 02:16:19.116 31870-31870/com.amaze.filemanager.debug W/System.err:     at java.lang.reflect.Method.invoke(Native Method)
2021-02-14 02:16:19.116 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:516)
2021-02-14 02:16:19.116 31870-31870/com.amaze.filemanager.debug W/System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)
2021-02-14 02:16:19.119 31870-31870/com.amaze.filemanager.debug W/System.err: Caused by: android.system.ErrnoException: open failed: ENOENT (No such file or directory)
2021-02-14 02:16:19.119 31870-31870/com.amaze.filemanager.debug W/System.err:     at libcore.io.Linux.open(Native Method)
2021-02-14 02:16:19.121 31870-31870/com.amaze.filemanager.debug W/System.err:     at libcore.io.ForwardingOs.open(ForwardingOs.java:167)
2021-02-14 02:16:19.121 31870-31870/com.amaze.filemanager.debug W/System.err:     at libcore.io.BlockGuardOs.open(BlockGuardOs.java:252)
2021-02-14 02:16:19.121 31870-31870/com.amaze.filemanager.debug W/System.err:     at libcore.io.ForwardingOs.open(ForwardingOs.java:167)
2021-02-14 02:16:19.121 31870-31870/com.amaze.filemanager.debug W/System.err:     at android.app.ActivityThread$AndroidOs.open(ActivityThread.java:7542)
2021-02-14 02:16:19.121 31870-31870/com.amaze.filemanager.debug W/System.err:     at libcore.io.IoBridge.open(IoBridge.java:482)
2021-02-14 02:16:19.121 31870-31870/com.amaze.filemanager.debug W/System.err: 	... 18 more

Also added SshClientUtils version of checkFolder()

EmmanuelMess · 2021-03-14T17:50:16Z

@TranceLove this needs to be rebased

EmmanuelMess

Fixes issue and code seems ok

TranceLove added Issue-Bug Related unexpected behavior or something worth investigating. Area-FileOperations Related to file operations (e.g. moving, copying, renaming). Area-SMB Related to SMB connections. labels Jan 19, 2021

TranceLove added this to the v3.6 milestone Jan 19, 2021

TranceLove requested review from VishalNehra and EmmanuelMess January 19, 2021 09:56

EmmanuelMess requested changes Jan 19, 2021

View reviewed changes

app/src/main/java/com/amaze/filemanager/asynchronous/asynctasks/PrepareCopyTask.java Outdated Show resolved Hide resolved

TranceLove force-pushed the bugfix/2189 branch from a8dcb7d to 5f1fcb5 Compare January 19, 2021 15:05

EmmanuelMess previously approved these changes Jan 19, 2021

View reviewed changes

VishalNehra requested changes Jan 19, 2021

View reviewed changes

TranceLove dismissed EmmanuelMess’s stale review via 8926b59 January 20, 2021 10:06

TranceLove force-pushed the bugfix/2189 branch from 5f1fcb5 to 8926b59 Compare January 20, 2021 10:06

SMB version of MainActivityHelper.checkFolder()

648ad18

Fixes TeamAmaze#2189.

TranceLove force-pushed the bugfix/2189 branch from 8926b59 to 648ad18 Compare February 7, 2021 16:14

Merge branch 'release/3.6' into bugfix/2189

ea5aca2

TranceLove force-pushed the bugfix/2189 branch from 9364078 to ea5aca2 Compare February 7, 2021 16:27

VishalNehra requested changes Feb 7, 2021

View reviewed changes

app/src/main/java/com/amaze/filemanager/filesystem/FolderState.kt Show resolved Hide resolved

TranceLove force-pushed the bugfix/2189 branch 2 times, most recently from 70042e0 to 9279df6 Compare February 10, 2021 10:05

Fix test compile error

0ee37c0

TranceLove force-pushed the bugfix/2189 branch from 9279df6 to 0ee37c0 Compare February 10, 2021 10:07

Merge branch 'release/3.6' into bugfix/2189

08be206

TranceLove force-pushed the bugfix/2189 branch from 5537a03 to 08be206 Compare February 13, 2021 13:37

TranceLove force-pushed the bugfix/2189 branch from 776e03a to 9a5f103 Compare February 17, 2021 08:20

Fix SmbUtil.checkFolder still not being called from PrepareCopyTask

09fcee5

Also added SshClientUtils version of checkFolder()

TranceLove force-pushed the bugfix/2189 branch from 9a5f103 to 09fcee5 Compare February 17, 2021 08:25

Merge branch 'release/3.6' into bugfix/2189

8639957

TranceLove force-pushed the bugfix/2189 branch from f9d40e6 to 8639957 Compare March 15, 2021 04:51

TranceLove added 2 commits March 16, 2021 17:55

Merge remote-tracking branch 'upstream/release/3.6' into bugfix/2189

4ea53da

Fix test error (again)

b4a8b5c

EmmanuelMess approved these changes Mar 17, 2021

View reviewed changes

VishalNehra removed this from the v3.6 milestone Apr 25, 2021

VishalNehra approved these changes Apr 25, 2021

View reviewed changes

VishalNehra merged commit 74e7bd9 into TeamAmaze:release/3.6 Apr 25, 2021

EmmanuelMess deleted the bugfix/2189 branch April 26, 2021 22:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SMB version of MainActivityHelper.checkFolder() #2229

SMB version of MainActivityHelper.checkFolder() #2229

TranceLove commented Jan 19, 2021 •

edited

Loading

VishalNehra commented Jan 19, 2021

TranceLove commented Jan 20, 2021

VishalNehra commented Jan 27, 2021

VishalNehra commented Feb 13, 2021

VishalNehra commented Feb 13, 2021 •

edited

Loading

EmmanuelMess commented Mar 14, 2021

EmmanuelMess left a comment

SMB version of MainActivityHelper.checkFolder() #2229

SMB version of MainActivityHelper.checkFolder() #2229

Conversation

TranceLove commented Jan 19, 2021 • edited Loading

PR Info

Issue tracker

Release

Test cases

Manual testing

Build tasks success

Additional Info

VishalNehra commented Jan 19, 2021

TranceLove commented Jan 20, 2021

VishalNehra commented Jan 27, 2021

Issue explanation (write below this line)

Exception

VishalNehra commented Feb 13, 2021

VishalNehra commented Feb 13, 2021 • edited Loading

EmmanuelMess commented Mar 14, 2021

EmmanuelMess left a comment

Choose a reason for hiding this comment

TranceLove commented Jan 19, 2021 •

edited

Loading

VishalNehra commented Feb 13, 2021 •

edited

Loading