Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 404 and 500 pages #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added 404 and 500 pages #9

wants to merge 2 commits into from

Conversation

jayasi
Copy link
Contributor

@jayasi jayasi commented Aug 13, 2015

No description provided.

<meta name="csrf-token" content="7CZFCDlIOrVe/vFDj8hml6BwwkbdI9ifYiGbxlikx9jo1cH10ovX3sJGuqSoLFq/D8bLsTa4hRLtAdlqNEObmQ==">
<link rel="stylesheet" media="all" href="/assets/rails_admin/rails_admin-aa8fcab07991cfc251160f921e9001fd.css?body=1">
<script src="/assets/jquery-2ebc4d7dee7ed5002a2ec81cda5c42ea.js?body=1"></script>
<script src="/assets/rails_admin/bootstrap/bootstrap-transition-349e2c80e43210f20936b0c48cb0322f.js?body=1"></script>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we regenerate these error files every time we deploy? The URL has the hash fragment for the asset which doesn't get updated unless the task asset:precompile is run before we deploy. That is the reason why the CSS is included in the HTML markup in the older version. How are we ensuring that these get updated for every deployment?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. We do run asset:precompile for deploys 🤦 Don't know what I was thinking.

My intended question was, do these files get regenerated with the updated hash fragment every time we deploy? How does that work in Dev environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I wasn't aware of that. Had decided to include the assets to have a similar theme to our 404 and 500 pages as we have in the rest of the site.

What do you suggest we do?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, these should be simple. If you have to use bootstrap, better way would be to use a hosted version or put another set of bootstrap minified assets under a directory in public/ and link them instead.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there's one more way. You can make them dynamic like any other web page in the app by using a flag and using a controller and reroute the user to a specific page. I'll set up an example to better explain this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants