Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/workflows-checkbox #302

Closed
wants to merge 9 commits into from

Conversation

tdari
Copy link
Contributor

@tdari tdari commented Jun 20, 2024

This PR will add checkboxes to the workflow list to control workflows by choosing desired workflows.

Also, #298 will be implemented.

Initial design:

image

@vinicvaz
Copy link
Collaborator

This is amazing @tdari ! Will it be multi select? Maybe we can keep at least the run button for a single workflow.

Let me ask you something, do you have an email or linkedin I can contact you?

@tdari
Copy link
Contributor Author

tdari commented Jun 20, 2024

Hey @vinicvaz, yes it will be multi select. Users can select a single workflow to take action but we can add an action menu for every workflow if you prefer that. I sent you a connection request.

@vinicvaz
Copy link
Collaborator

vinicvaz commented Jun 20, 2024

@tdari Yeah, I asked the run button just to keep things simple to single workflows. The checkboxes are really good for multi select but for quick actions the run button is great. I think we should keep both for run. The others (delete and pause) we can use only checkboxes.

btw, I added a dedicated section to the CLI on docs, it will be online soon

@tdari tdari force-pushed the feat/workflows-checkbox branch from 4b8492a to 612e983 Compare June 26, 2024 18:51
@tdari tdari changed the title feat(frontend): add checkbox to workflow list feat(frontend)/workflow-list-enhancement Jun 26, 2024
@tdari tdari closed this Jun 26, 2024
@tdari tdari deleted the feat/workflows-checkbox branch June 26, 2024 19:02
@tdari tdari restored the feat/workflows-checkbox branch June 26, 2024 19:05
@tdari
Copy link
Contributor Author

tdari commented Jun 26, 2024

Hey @vinicvaz, I accidentally closed this PR by renaming the branch can you somehow re-open this so we can keep the history? I couldn't find a way to reopen it. The reopen button is disabled on my screen.

@tdari tdari changed the title feat(frontend)/workflow-list-enhancement feat/workflows-checkbox Jun 26, 2024
@vinicvaz
Copy link
Collaborator

vinicvaz commented Jun 27, 2024

@tdari I can't reopen it because there is a force push to the repo. Here is a (old) discussion about
this isaacs/github#361 (comment)

You can create a new branch from the base and open a new pr, no prob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants