Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): upstream option for anyof array #266

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

nathan-vm
Copy link
Contributor

@nathan-vm nathan-vm commented Apr 2, 2024

@nathan-vm nathan-vm self-assigned this Apr 2, 2024
@nathan-vm nathan-vm requested a review from vinicvaz April 2, 2024 17:00
@nathan-vm nathan-vm added the bug Something isn't working label Apr 2, 2024
@vinicvaz
Copy link
Collaborator

vinicvaz commented Apr 3, 2024

anyOf(string, null) is rendering same options as anyOf(string, null, int, float, date, etc).
We should render only the allowed types.
For example, in email sender piece the arg_value of the InnerArgModel is typed as Optional[str] and the upstream options is allowing we select all types from Log piece.
image
image

@vinicvaz
Copy link
Collaborator

vinicvaz commented Apr 3, 2024

@nathan-vm
Now is good but I think we should validate fields with "format" as well for generating upstream options.
The way we have we are accepting date, datetime, time, enum in string fields.
Strings without any format are pure strings
Strings with date must connect only with strings with date, the same for time, datetime, etc.

@vinicvaz vinicvaz merged commit 0a99aac into dev Apr 3, 2024
@vinicvaz vinicvaz deleted the fix/upstream-option-for-anyof-array branch April 3, 2024 20:37
@vinicvaz vinicvaz mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants