-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional before and after slivers to sandwich the list. #40
base: development
Are you sure you want to change the base?
Conversation
thanks for the PR) I'm actually not sure if these changes are needed. This package is about sticky headers, for custom scrollable containers you can always use widget items independently and build any scrollable container as you want |
like this one |
You meant to say since I was just thinking that when you add more stuff to What do you think? |
yep,
I agree that divider might be helpful since it's part of the overall list. As for |
@wiradikusuma I just published v3 for 1.20 flutter support, so I changed base branch for this PR |
I'm thinking, what if instead of making this class full of different keys, just change some of the properties to make them public? For instance slivers keys and so on, in that way you can just extent this class and adjust any key you want |
I thought of suggesting that initially, but I believe Flutter's philosophy for widgets is composition over inheritance. |
Well yes, composition over inheritance is something that flutter prefer, but it's not writen in the stone. You can actually find some of the widgets out of the box, that was made for extend rather than for composition. But, adding bunch of generic properties that doesn't fit to the responsibility of the widget is less attractive than extend) I would probably think about something more flexible like delegate rather than params |
Sometimes you have your own slivers in addition to the list, e.g. a
SliverPersistentHeader
on top andSliverToBoxAdapter
at the bottom. These 2 properties allow you to do that.Dart version bumped to 2.2.2 to make use of the spread operator.