Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spread table options in lit adapter #5904

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

kadoshms
Copy link
Contributor

@kadoshms kadoshms commented Feb 5, 2025

Currently the Lit adapter takes only columns, data and state into account when updating the table options.
This PR spreads the options, as suggested in this issue.

Copy link

nx-cloud bot commented Feb 5, 2025

View your CI Pipeline Execution ↗ for commit 8a90448.

Command Status Duration Result
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-06 06:49:32 UTC

Copy link

nx-cloud bot commented Feb 5, 2025

View your CI Pipeline Execution ↗ for commit 5504cbe.


☁️ Nx Cloud last updated this comment at 2025-02-05 14:42:06 UTC

Copy link

pkg-pr-new bot commented Feb 5, 2025

Open in Stackblitz

More templates

@tanstack/angular-table

npm i https://pkg.pr.new/@tanstack/angular-table@5904

@tanstack/lit-table

npm i https://pkg.pr.new/@tanstack/lit-table@5904

@tanstack/qwik-table

npm i https://pkg.pr.new/@tanstack/qwik-table@5904

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/@tanstack/match-sorter-utils@5904

@tanstack/react-table

npm i https://pkg.pr.new/@tanstack/react-table@5904

@tanstack/react-table-devtools

npm i https://pkg.pr.new/@tanstack/react-table-devtools@5904

@tanstack/solid-table

npm i https://pkg.pr.new/@tanstack/solid-table@5904

@tanstack/svelte-table

npm i https://pkg.pr.new/@tanstack/svelte-table@5904

@tanstack/table-core

npm i https://pkg.pr.new/@tanstack/table-core@5904

@tanstack/vue-table

npm i https://pkg.pr.new/@tanstack/vue-table@5904

commit: 8a90448

@KevinVandy KevinVandy merged commit 36dede1 into TanStack:main Feb 10, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants