Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): fix nx graph detection #3271

Conversation

beaussan
Copy link
Contributor

@beaussan beaussan commented Jan 29, 2025

On Nx 20.3.2 and 20.3.3, this issue got fixed: nrwl/nx#29486
However, on Nx 20.4 Nx reverted the fix, causing the graph to be missing the link between the feature library and the application

The temporary workaround is to define a implicitDependencies on the project to force the link between the two projects

Copy link

nx-cloud bot commented Jan 29, 2025

View your CI Pipeline Execution ↗ for commit 17619ee.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 6m 49s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-30 06:17:34 UTC

Copy link

pkg-pr-new bot commented Jan 29, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3271

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3271

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3271

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3271

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3271

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3271

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3271

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3271

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3271

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3271

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3271

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3271

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3271

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3271

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3271

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3271

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3271

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3271

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3271

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3271

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3271

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3271

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3271

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3271

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3271

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3271

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3271

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3271

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3271

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3271

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3271

commit: 17619ee

@beaussan beaussan marked this pull request as ready for review January 29, 2025 08:21
@SeanCassiere
Copy link
Member

SeanCassiere commented Jan 30, 2025

cc-ing @schiller-manuel since the exclude in the root package.json was added in #3270.

Edit: Got the 👍🏼

@SeanCassiere SeanCassiere merged commit 2a90490 into TanStack:main Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NX Packages without default export are excluded from dependencies
2 participants