Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-router): add remountDeps #3269

Merged
merged 1 commit into from
Jan 29, 2025
Merged

feat(react-router): add remountDeps #3269

merged 1 commit into from
Jan 29, 2025

Conversation

schiller-manuel
Copy link
Contributor

@schiller-manuel schiller-manuel commented Jan 28, 2025 •
edited
Loading

closes #2990

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c9f8f74.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 1m 19s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-29 00:02:32 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 28, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3269

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3269

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3269

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3269

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3269

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3269

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3269

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3269

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3269

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3269

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3269

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3269

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3269

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3269

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3269

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3269

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3269

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3269

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3269

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3269

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3269

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3269

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3269

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3269

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3269

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3269

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3269

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3269

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3269

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3269

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3269

commit: c9f8f74

@schiller-manuel schiller-manuel merged commit 34d0350 into main Jan 29, 2025
4 of 5 checks passed
@schiller-manuel schiller-manuel deleted the remountDeps branch January 29, 2025 00:03
tannerlinsley added a commit that referenced this pull request Jan 29, 2025
@schiller-manuel @tannerlinsley
@SeanCassiere @Sheraff @autofix-ci @djgrant
fix: Fix scroll restoration (#3191)
fdaefc0 
* fix: scroll-restoration (especially on hydration mismatch)

* fix: more fixes

* fix canGoBack

* release: v1.97.25

* chore(root): upgrade `vitest` to `3.0.4` (#3257)

* chore(root): upgrade `nx` to `20.4.0` (#3259)

* fix(react-router): improve error handling for module loading failures in lazyRouteComponent (#3262)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* fix(start-server): remove debugging timeout (#3258)

* fix(start-plugin): invoke server implementation of createIsomorphicFn during SSR (#3268)

* feat(react-router): add `remountDeps` (#3269)

* fix: RELEASE_ALL

RELEASE_ALL

* examples: remove dep (#3270)

* release: v1.98.0

* checkpoint

* fix tests

* tests: fix

* fix: back to old onRendered

* fix: scroll-restoration (especially on hydration mismatch)

* fix: more fixes

* fix canGoBack

* checkpoint

* fix tests

* tests: fix

* fix: back to old onRendered

* Move utils to core

* fix: backwards compat ScrollRestoration

* fix: better versioning

* fix: reenable hash scrolling and window reset even without scroll restoration

* test(e2e): renable tests for router

* fix: backwards compat and docs

---------

Co-authored-by: Tanner Linsley <[email protected]>
Co-authored-by: Tanner Linsley <[email protected]>
Co-authored-by: Sean Cassiere <[email protected]>
Co-authored-by: Flo <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Daniel Grant <[email protected]>
schiller-manuel added a commit that referenced this pull request Jan 30, 2025
@schiller-manuel
tests: notFound handling in notFound when SSRing
faded5c 
the actual fix was accidentally included in #3269
@schiller-manuel schiller-manuel mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No builtin mechanism for remounting on path param changes
1 participant
@schiller-manuel