Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): ignore queryClient from exhaustive-check #5291

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

Newbie012
Copy link
Collaborator

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Apr 21, 2023 11:19am

@nx-cloud
Copy link

nx-cloud bot commented Apr 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8859c3a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8859c3a:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +4.92 🎉

Comparison is base (98be9ec) 92.20% compared to head (8859c3a) 97.12%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5291      +/-   ##
==========================================
+ Coverage   92.20%   97.12%   +4.92%     
==========================================
  Files          39       11      -28     
  Lines        1257      383     -874     
  Branches      355      140     -215     
==========================================
- Hits         1159      372     -787     
+ Misses         92       11      -81     
+ Partials        6        0       -6     
Impacted Files Coverage Δ
.../src/rules/exhaustive-deps/exhaustive-deps.rule.ts 100.00% <100.00%> (ø)
...src/rules/exhaustive-deps/exhaustive-deps.utils.ts 100.00% <100.00%> (ø)

... and 48 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel
Copy link

vercel bot commented Apr 21, 2023

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@TkDodo TkDodo merged commit 058f030 into TanStack:main Apr 21, 2023
@Newbie012 Newbie012 deleted the fix-eslint-plugin-ignore-query-client branch April 21, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants