Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching to an affected strategy #5215

Merged
merged 27 commits into from
Apr 2, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
3fa18b0
switiching to an affected strategy
ZackDeRose Apr 1, 2023
ec8119c
updating base affected option for ci and ci-v3 workflows
ZackDeRose Apr 1, 2023
ac2768e
Update .github/workflows/ci-v3.yml
ZackDeRose Apr 1, 2023
f94478e
checking github context
ZackDeRose Apr 1, 2023
5c4a65d
checking pnpm version
ZackDeRose Apr 1, 2023
de82439
fix?
ZackDeRose Apr 1, 2023
63abd49
does not like main - let's use a sha then
ZackDeRose Apr 1, 2023
a834d44
checking git head
ZackDeRose Apr 1, 2023
e8a3385
checking git in general
ZackDeRose Apr 1, 2023
01b759c
fix????
ZackDeRose Apr 1, 2023
924a0e7
fix???????? pleeeease
ZackDeRose Apr 1, 2023
76fd7eb
still in detatched head state
ZackDeRose Apr 1, 2023
95d0b5a
try checking out the pr head sha?
ZackDeRose Apr 1, 2023
137864c
checking out pr branch
ZackDeRose Apr 1, 2023
cb22574
checking githubref
ZackDeRose Apr 1, 2023
876e779
full gh ref
ZackDeRose Apr 1, 2023
947eef4
dumping context again
ZackDeRose Apr 1, 2023
975809b
try to checkout head ref
ZackDeRose Apr 1, 2023
5958544
adding repo prop
ZackDeRose Apr 1, 2023
9794998
git logging
ZackDeRose Apr 1, 2023
72e2e40
trying with sha for base
ZackDeRose Apr 1, 2023
3d1e909
fixing other jobs
ZackDeRose Apr 1, 2023
c4fe0c4
fixing other jobs again
ZackDeRose Apr 1, 2023
4d02a3b
reverting root specific projects to run many
ZackDeRose Apr 1, 2023
dab2732
removing special stuff from build test
ZackDeRose Apr 1, 2023
4bce4a7
testing affected
ZackDeRose Apr 1, 2023
529bc0a
reverting change
ZackDeRose Apr 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-v3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
node-version: ${{ matrix.node }}
- name: Install dependencies
uses: bahmutov/npm-install@v1
- run: yarn test:ci
- run: yarn test:ci --base=${{ github.event.before }}
ZackDeRose marked this conversation as resolved.
Show resolved Hide resolved
env:
REACTJS_VERSION: ${{ matrix.react }}
- run: yarn test:size
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Run Tests
uses: nick-fields/[email protected]
with:
command: pnpm run test:ci
command: pnpm run test:ci --base=${{ github.event.before }}
timeout_minutes: 10
max_attempts: 3
- name: Publish
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
cache: 'pnpm'
- name: Install dependencies
run: pnpm --filter "./packages/**" --filter query --prefer-offline install
- run: pnpm run test:eslint
- run: pnpm run test:eslint --base=${{ github.base_ref }}
typecheck:
name: 'Typecheck'
runs-on: ubuntu-latest
Expand All @@ -56,7 +56,7 @@ jobs:
cache: 'pnpm'
- name: Install dependencies
run: pnpm --filter "./packages/**" --filter query --prefer-offline install
- run: pnpm run test:types
- run: pnpm run test:types --base=${{ github.base_ref }}
format:
name: 'Format'
runs-on: ubuntu-latest
Expand All @@ -71,7 +71,7 @@ jobs:
cache: 'pnpm'
- name: Install dependencies
run: pnpm --filter "./packages/**" --filter query --prefer-offline install
- run: pnpm run test:format
- run: pnpm run test:format --base=${{ github.base_ref }}
test-react-17:
name: 'Test React 17'
runs-on: ubuntu-latest
Expand All @@ -91,7 +91,7 @@ jobs:
with:
timeout_minutes: 5
max_attempts: 3
command: pnpm run test:react:17
command: pnpm run test:react:17 --base=${{ github.base_ref }}
env:
REACTJS_VERSION: 17
test-build:
Expand All @@ -108,6 +108,6 @@ jobs:
cache: 'pnpm'
- name: Install dependencies
run: pnpm --filter "./packages/**" --filter query --prefer-offline install
- run: pnpm run test:build
- run: pnpm run test:build --base=${{ github.base_ref }}
env:
BUNDLEWATCH_GITHUB_TOKEN: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@
"preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...'); process.exit(1)}\" || npx -y only-allow pnpm",
"install:csb": "pnpm install --frozen-lockfile",
"test": "pnpm run test:ci",
"test:ci": "nx run-many --targets=test:lib,test:types,test:eslint,test:format --parallel=5",
"test:react:17": "nx run-many --target=test:lib --projects=@tanstack/react-*",
"test:eslint": "nx run-many --target=test:eslint --parallel=5",
"test:ci": "nx affected --targets=test:lib,test:types,test:eslint,test:format --parallel=5",
"test:react:17": "nx affected --target=test:lib --projects=@tanstack/react-*",
"test:eslint": "nx affected --target=test:eslint --parallel=5",
"test:format": "pnpm run prettier --check",
"test:lib": "nx run-many --target=test:lib --parallel=5",
"test:lib": "nx affected --target=test:lib --parallel=5",
"test:lib:dev": "pnpm --filter \"./packages/**\" run test:lib:dev",
"test:build": "nx run-many --target=test:build --projects=root",
"test:types": "nx run-many --target=test:types --parallel=5",
"build": "nx run-many --target=build --projects=root",
"build:types": "nx run-many --target=build:types --parallel=5",
"test:build": "nx affected --target=test:build --projects=root",
"test:types": "nx affected --target=test:types --parallel=5",
"build": "nx affected --target=build --projects=root",
"build:types": "nx affected --target=build:types --parallel=5",
"watch": "concurrently --kill-others \"rollup --config rollup.config.js -w\" \"pnpm run build:types --watch\"",
"dev": "pnpm run watch",
"prettier": "prettier --plugin-search-dir . \"{packages,examples}/**/src/**/*.{md,js,jsx,ts,tsx,json,vue,svelte}\"",
Expand Down