Local Task Caching for all Revelant tasks #5134

ZackDeRose · 2023-03-15T05:19:01Z

What this does

Makes all relevant tasks cacheable
From the perspective of calling the existing pnpm scripts, all scripts should result in the same behavior as before; with the exceptions that:
1. Nx is now being used as the task runner
2. Some commands that were sequential are now parallelized where it made sense to parallelize
3. Some commands are cacheable where it made sense to cache task results

vercel · 2023-03-15T05:19:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
query	⬜️ Ignored (Inspect)			Mar 16, 2023 at 7:54PM (UTC)

codesandbox-ci · 2023-03-15T05:20:40Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2e61af4:

Sandbox	Source
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration

codecov-commenter · 2023-03-15T05:23:11Z

Codecov Report

Patch coverage has no change and project coverage change: +0.31 🎉

Comparison is base (b8b0562) 91.90% compared to head (f5390fd) 92.22%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5134      +/-   ##
==========================================
+ Coverage   91.90%   92.22%   +0.31%     
==========================================
  Files         111      111              
  Lines        4188     4229      +41     
  Branches     1083     1099      +16     
==========================================
+ Hits         3849     3900      +51     
+ Misses        318      308      -10     
  Partials       21       21

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ZackDeRose · 2023-03-16T00:11:12Z

nx.json

+  "pluginsConfig": {
+    "@nrwl/js": {
+      "analyzeSourceFiles": false
+    }
+  },


short explanation: this exlicitely states our depency graph strategy - which is to analyze deps based on package.json files. This was the behavior we are already using.

long explanation: I added the @nrwl/workspace briefly to this PR, and while I ended up not needing it, it appears that this changes the default behavior to determine deps by source file analysis. I want to leave this here so this isn't a surprise in case we end up introducing other nx plugins later on!

ZackDeRose · 2023-03-16T00:15:20Z

nx.json

+    "test:types": {
+      "outputs": [
+        "{projectRoot}/build/lib/**/*.d.ts",
+        "{projectRoot}/build/.tsbuildinfo"
+      ],
+      "inputs": ["default", "^public"],
+      "dependsOn": ["^test:types"]
+    },
+    "build:types": {
+      "outputs": ["{projectRoot}/build"],
+      "inputs": ["default", "^public"],
+      "dependsOn": ["^build:types"]
+    },


Interestingly, test:types and build:types scripts tend to do the same things:

test:types: tsc
build:types: tsc --build

If I'm not mistaken, the build option is true by default, so these are equivalent. If we want to not write to disk on the test:types I think we can use: test:types --build=false, but we'll need to make sure that the builds we depend on happen first for this to work correctly!

@TkDodo - if we want to make the adjustment above, can you create a new issue for this? And feel free to assign to me.

I'd like for this PR to be a like-for-like as much as possible so we don't change any behaviors!

ZackDeRose · 2023-03-16T00:20:52Z

package.json

+  "nx": {
+    "includedScripts": [
+      "test:format",
+      "build",
+      "test:build"
+    ]
+  },


Adding this property creates an "include list" of the package.json scripts that nx will include in it's task graph.

If this property is not set, all package scripts become "tasks" that nx can find and run (for example via nx test:types @tanstack/query-core and nx run-many --target=test:types)

My intention in adding this property is actually to make sure we exclude:

test:eslint

test:types

build

build:types

scripts, so that calling these do not infinitely recurse when we call pnpm build for example!

ZackDeRose · 2023-03-16T00:22:04Z

project.json

@@ -0,0 +1,28 @@
+{


this file creates the concept of a "project" for nx at the source root, so we can define and run some root-level scripts

ZackDeRose · 2023-03-16T00:23:37Z

scripts/project.json

@@ -0,0 +1,8 @@
+{


this defines a scripts project in our workspace for nx inside the scripts directory.

With this, we can now call: nx test:eslint scripts to lint our scripts, and what's cooler, we can now just "add this to the pile" by calling nx run-many --target=test:eslint inside of our package scripts/ci stuff :)

ZackDeRose · 2023-03-16T07:25:06Z

package.json

+    "test:build": "nx test:build root",
+    "test:types": "nx run-many --target=test:types --parallel=5",
+    "build": "nx run-many --target=build --projects=root,@tanstack/eslint-plugin-query",
+    "build:types": "nx run-many --target=build:types --parallel=5",
    "watch": "concurrently --kill-others \"rollup --config rollup.config.js -w\" \"pnpm run build:types --watch\"",


We might be able to use nx watch here for the watch command - but I'll keep that separate from this pr

ZackDeRose · 2023-03-16T07:31:45Z

project.json

+      }
+    }
+  },
+  "implicitDependencies": ["**/*"]


This marks our root nx project as dependent on all packages. We use this to inform our caching - as you can see in the nx.json file, the inputs for the build target is the public files of all dependencies.

ZackDeRose · 2023-03-16T07:37:36Z

project.json

+    "build": {
+      "executor": "nx:run-commands",
+      "options": {
+        "commands": [
+          "rollup --config rollup.config.js",
+          "nx run-many --target=build:types",
+          "nx build @tanstack/eslint-plugin-query",
+          "nx build @tanstack/svelte-query"
+        ],
+        "parallel": true
+      }
+    },


Build should do these 4 things, and it can actually do all 4 in independently if we want, so that's what we're doing here.

Interestingly @tanstack/svelte-query has it's own build step, but all other packages are built in 1 go with the rollup command it appears.

@TkDodo - let me know if there's a preference here, we might be able to get some boost by parallelizing the package builds and running them individually (this also allows the cache to be more granular - as it stands we need to "invalidate" the build cache for all projects whenever a single project's public code is touched 🥶

If we do want to break it up, let's do it in another PR! As I mention elsewhere, I'd like to keep this one as "like-for-like" as possible!

TkDodo · 2023-03-17T08:15:41Z

I think I spotted an issue with the test:format task. I've formatted everything correctly, run the task. Then made a change in a tsx file, run the task again, but it just reads from the cache:

> nx test:format root


> nx run root:test:format  [existing outputs match the cache, left as is]

I then tried with --skip-nx-cache and the error showed up:

> nx test:format root "--skip-nx-cache"


> nx run root:"test:format"

> query@ prettier /Users/dodo/work/TanStackQuery
> prettier --plugin-search-dir . "{packages,examples}/**/src/**/*.{md,js,jsx,ts,tsx,json,vue,svelte}" "--check"
Checking formatting...
[warn] packages/react-query-devtools/src/devtools.tsx
[warn] Code style issues found in the above file. Forgot to run Prettier?
 ELIFECYCLE  Command failed with exit code 1.
 >  NX   ERROR: Something went wrong in run-commands - Command failed: pnpm run prettier --check

ZackDeRose · 2023-03-17T08:41:04Z

I must've misconfigured the cache here - on it now!

ZackDeRose · 2023-03-17T09:01:31Z

fix up: #5147

^ demo video to show this working now :)

We should definitely be vigilant against false positives like this!

caching added for eslint for packages

53efce5

ZackDeRose added 7 commits March 14, 2023 22:23

project definition added for scripts project and test:eslint target

911cc29

adding task caching for test:types

ac54a97

adding appropriate dependsOn and outputs to test:types

8e38c46

updating test:react:17

a11c2e1

running many on test:ci for nx scripts

2cad67d

adding output to test:types

a78aa3c

adding root project and format task

4dc5a6d

ZackDeRose force-pushed the test-process-caching branch from ec895b9 to 4dc5a6d Compare March 15, 2023 06:50

ZackDeRose added 5 commits March 15, 2023 15:12

adding caching for build and test:build

e021efc

fixing frozen lockfile error in ci

d4ec024

fixing pnpm build to include the build of the eslin-plugin

d2ffb04

adding build for svelte-query as well

05f7315

parallelizing bundlewatch and validate pacakges script

b5ff2cb

ZackDeRose changed the title ~~Local Task Caching added for Eslint for packages~~ Local Task Caching for all Revelant tasks Mar 16, 2023

ZackDeRose commented Mar 16, 2023

View reviewed changes

cleaning up a bit more

f5390fd

ZackDeRose commented Mar 16, 2023

View reviewed changes

moving build config to the root project

2e61af4

TkDodo approved these changes Mar 17, 2023

View reviewed changes

TkDodo merged commit 8e13afa into TanStack:main Mar 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Local Task Caching for all Revelant tasks #5134

Local Task Caching for all Revelant tasks #5134

ZackDeRose commented Mar 15, 2023 •

edited

Loading

vercel bot commented Mar 15, 2023 •

edited

Loading

codesandbox-ci bot commented Mar 15, 2023 •

edited

Loading

codecov-commenter commented Mar 15, 2023 •

edited

Loading

ZackDeRose Mar 16, 2023

ZackDeRose Mar 16, 2023

ZackDeRose Mar 16, 2023

ZackDeRose Mar 16, 2023 •

edited

Loading

ZackDeRose Mar 16, 2023

ZackDeRose Mar 16, 2023 •

edited

Loading

ZackDeRose Mar 16, 2023

ZackDeRose Mar 16, 2023

ZackDeRose Mar 16, 2023

TkDodo commented Mar 17, 2023

ZackDeRose commented Mar 17, 2023

ZackDeRose commented Mar 17, 2023

Local Task Caching for all Revelant tasks #5134

Local Task Caching for all Revelant tasks #5134

Conversation

ZackDeRose commented Mar 15, 2023 • edited Loading

What this does

vercel bot commented Mar 15, 2023 • edited Loading

codesandbox-ci bot commented Mar 15, 2023 • edited Loading

codecov-commenter commented Mar 15, 2023 • edited Loading

Codecov Report

ZackDeRose Mar 16, 2023

Choose a reason for hiding this comment

ZackDeRose Mar 16, 2023

Choose a reason for hiding this comment

ZackDeRose Mar 16, 2023

Choose a reason for hiding this comment

ZackDeRose Mar 16, 2023 • edited Loading

Choose a reason for hiding this comment

ZackDeRose Mar 16, 2023

Choose a reason for hiding this comment

ZackDeRose Mar 16, 2023 • edited Loading

Choose a reason for hiding this comment

ZackDeRose Mar 16, 2023

Choose a reason for hiding this comment

ZackDeRose Mar 16, 2023

Choose a reason for hiding this comment

ZackDeRose Mar 16, 2023

Choose a reason for hiding this comment

TkDodo commented Mar 17, 2023

ZackDeRose commented Mar 17, 2023

ZackDeRose commented Mar 17, 2023

ZackDeRose commented Mar 15, 2023 •

edited

Loading

vercel bot commented Mar 15, 2023 •

edited

Loading

codesandbox-ci bot commented Mar 15, 2023 •

edited

Loading

codecov-commenter commented Mar 15, 2023 •

edited

Loading

ZackDeRose Mar 16, 2023 •

edited

Loading

ZackDeRose Mar 16, 2023 •

edited

Loading