fix(eslint-plugin): improve object property checks #5079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 381ea96:
|
Newbie012
commented
Mar 5, 2023
| @@ -87,7 +87,7 @@ ruleTester.run('exhaustive-deps', rule, { | |||
| type Result = {}; | |||
| function MyComponent(props) { | |||
| useQuery({ | |||
| queryKey: ["foo", dep1], | |||
| queryKey: ["foo", dep], | |||
There was a problem hiding this comment.
Not sure how I missed it.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #5079 +/- ##
=======================================
Coverage 91.88% 91.89%
=======================================
Files 111 111
Lines 4179 4184 +5
Branches 1082 1083 +1
=======================================
+ Hits 3840 3845 +5
Misses 318 318
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TkDodo
reviewed
Mar 6, 2023
packages/eslint-plugin-query/src/rules/exhaustive-deps/exhaustive-deps.test.ts
Show resolved
Hide resolved
TkDodo
pushed a commit
to paul-sachs/query
that referenced
this pull request
Mar 15, 2023
* fix(eslint-plugin): improve object property checks * prettier
TkDodo
added a commit
that referenced
this pull request
Mar 15, 2023
…#4352) * feat(devtools): enable setting loading/error via devtools * Some cleanup * refactor: use flex-gap to align buttons * refactor: fix linter and dropdown reset * refactor: operate directly on activeQuery * Change buttons to toggle states * Sneak some queryState into meta * Added test for error and loading * Fix lint * Fix prettier formatting * chore: releases should run on alpha/beta as well * chore: extract package validation to an extra script (#5039) * chore: extract package validation to an extra script and run it during CI * chore: add missing `build:types` script to solid-query * docs: update link for v2 docs (#5044) * docs: update link for v2 docs * Update README.md --------- Co-authored-by: Dominik Dorfmeister <[email protected]> * release: v4.24.12 * fix(react-query-devtools): do not stretch query status label (#5063) Do not stretch query status label (fresh, fetching, paused, stale, inactive) shown on Query Details view. * release: v4.24.13 * fix(react-query-devtools): add 'use client' directive to disable SSR (#5041) Co-authored-by: Dominik Dorfmeister <[email protected]> * release: v4.24.14 * feat(core): re-export matchQuery from utils (#5070) Co-authored-by: Dominik Dorfmeister <[email protected]> * release: v4.25.0 * feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache (#5075) * feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache * test: tests for query onSettled callback * test: tests for mutation onSettled callback * docs: onSettled callbacks * release: v4.26.0 * fix(core): make sure mutations get updated options (#5085) this fixes an issue around stale closures where callbacks are not updated, thus are called with wrong values in the closure * release: v4.26.1 * fix(eslint-plugin): improve object property checks (#5079) * fix(eslint-plugin): improve object property checks * prettier * release: v4.26.2 * docs: add adapter dropdown to issue template (#5108) * docs(queries): rename `success` (#5110) * chore: `test:lib` task-caching w/ Nx (#5116) * adding quick caching test * reverting workflow change * updating pr yml to test nx speed * fixing yml on property * fixing yml on property * fixing target name * upping to running4 in parallel * upping to running 5 in parallel * upping to running 6 in parallel * upping to running 7 in parallel * upping to running 8 in parallel * upping to running 9 in parallel * upping to running 10 in parallel * opting for --parallel=5 * cleaning up nx.json * revert touching of ci.yml file * reverting on property of pr.yml file * updating root pacakge.json test:lib command * fixing frozen lockfile error in ci --------- Co-authored-by: Dominik Dorfmeister <[email protected]> * chore: fix missing dependencies (#5127) * chore: include scripts directory in linting and fix issues * chore: add missing dependencies chalk and semver * chore: turning off Nx daemon in CI (#5128) * chore: downgrade chalk to v4 because v5 is ESM only (#5130) see: https://stackoverflow.com/questions/70309135/chalk-error-err-require-esm-require-of-es-module * fix(eslint-plugin): ignore internal properties (#5119) * chore: resolve merge conflicts --------- Co-authored-by: Dominik Dorfmeister <[email protected]> Co-authored-by: Abhijeet Singh <[email protected]> Co-authored-by: Tanner Linsley <[email protected]> Co-authored-by: janinegygax <[email protected]> Co-authored-by: Youssouf Oumar <[email protected]> Co-authored-by: remolueoend <[email protected]> Co-authored-by: Eliya Cohen <[email protected]> Co-authored-by: Damian Osipiuk <[email protected]> Co-authored-by: Leon Fong <[email protected]> Co-authored-by: Zachary DeRose <[email protected]> Co-authored-by: Zachary DeRose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5069