Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): filter out examples #4239

Merged
merged 3 commits into from
Sep 28, 2022
Merged

chore(ci): filter out examples #4239

merged 3 commits into from
Sep 28, 2022

Conversation

juliusmarminge
Copy link
Collaborator

Continuing on #4237, filter to only install packages and root dependencies on CI

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 28, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4adf579:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration

@juliusmarminge
Copy link
Collaborator Author

Don't need to explicitly tell it --frozen-lockfile since it's done automatically in CI environments.

@juliusmarminge
Copy link
Collaborator Author

juliusmarminge commented Sep 28, 2022

Also went ahead and removed all the yarn commands etc to keep coherency, added pnpm-lock.yaml to .gitignore's so that it's not committed inside the examples. Also included the lockfiles for npm and yarn in the root gitignore so that only the pnpm-lock.yaml from root can be committed

@TkDodo TkDodo merged commit d9478e0 into TanStack:main Sep 28, 2022
@juliusmarminge juliusmarminge deleted the filter-installs branch September 28, 2022 18:53
@TkDodo
Copy link
Collaborator

TkDodo commented Sep 28, 2022

interesting - the publish pipeline now fails with:

Run pnpm --filter ./packages/** --filter query install
None of the selected packages has a "./packages/query-broadcast-client-experimental" script

> query@ cipublish /home/runner/work/query/query
> ts-node scripts/publish.ts

sh: 1: ts-node: not found
 ELIFECYCLE  Command failed.
 WARN   Local package.json exists, but node_modules missing, did you mean to install?
Error: Process completed with exit code 1.

pretty weird @juliusmarminge ?

@TkDodo
Copy link
Collaborator

TkDodo commented Sep 28, 2022

ah, it's missing the quotes!

@juliusmarminge
Copy link
Collaborator Author

ah, it's missing the quotes!

oooh sorry missed the quotes on one of the jobs :/

@TkDodo
Copy link
Collaborator

TkDodo commented Sep 28, 2022

fixed: c566c3c (and fec3daa lol)

@p6l-richard p6l-richard mentioned this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants