chore: Update eslint config from alpha branch (#5632)

TanStack · Jun 27, 2023 · ddf6986 · ddf6986
1 parent d0388a9
commit ddf6986
Show file tree

Hide file tree

Showing 33 changed files with 960 additions and 939 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -6,53 +6,59 @@ const config = {
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
     'plugin:import/typescript',
-    'react-app',
     'prettier',
   ],
   env: {
-    es6: true,
+    browser: true,
+    es2020: true,
   },
   parserOptions: {
+    tsconfigRootDir: __dirname,
     project: './tsconfig.base.json',
     sourceType: 'module',
+    ecmaVersion: 2020,
   },
   settings: {
     'import/parsers': {
       '@typescript-eslint/parser': ['.ts', '.tsx'],
     },
     'import/resolver': {
-      node: true,
-      typescript: {
-        project: 'packages/*/tsconfig.json',
-      },
+      typescript: true,
     },
     react: {
       version: 'detect',
     },
   },
   rules: {
-    'react/jsx-key': ['error', { checkFragmentShorthand: true }],
     '@typescript-eslint/ban-types': 'off',
     '@typescript-eslint/ban-ts-comment': 'off',
-    '@typescript-eslint/consistent-type-imports': 'error',
+    '@typescript-eslint/consistent-type-imports': [
+      'error',
+      { prefer: 'type-imports' },
+    ],
     '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/no-empty-interface': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/no-unnecessary-condition': 'error',
     '@typescript-eslint/no-inferrable-types': [
       'error',
-      {
-        ignoreParameters: true,
-      },
+      { ignoreParameters: true },
     ],
-    'no-shadow': 'error',
     'import/no-cycle': 'error',
     'import/no-unresolved': ['error', { ignore: ['^@tanstack/'] }],
     'import/no-unused-modules': ['off', { unusedExports: true }],
     'no-redeclare': 'off',
-    'react-hooks/exhaustive-deps': 'error',
+    'no-shadow': 'error',
   },
+  overrides: [
+    {
+      files: ['**/*.test.{ts,tsx}'],
+      rules: {
+        '@typescript-eslint/no-unnecessary-condition': 'off',
+      },
+    },
+  ],
 }
 
 module.exports = config
diff --git a/examples/react/algolia/.eslintrc b/examples/react/algolia/.eslintrc
@@ -1,7 +1,7 @@
 {
-  "extends": ["react-app", "prettier", "plugin:@tanstack/eslint-plugin-query/recommended"],
-  "rules": {
-    "react/jsx-uses-react": "off",
-    "react/react-in-jsx-scope": "off"
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended",
+    "plugin:@tanstack/eslint-plugin-query/recommended"
+  ]
 }
diff --git a/examples/react/basic-graphql-request/.eslintrc b/examples/react/basic-graphql-request/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/basic-typescript/.eslintrc b/examples/react/basic-typescript/.eslintrc
@@ -1,3 +1,7 @@
 {
-  "extends": ["react-app", "prettier", "plugin:@tanstack/eslint-plugin-query/recommended"]
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended",
+    "plugin:@tanstack/eslint-plugin-query/recommended"
+  ]
 }
diff --git a/examples/react/basic-typescript/package.json b/examples/react/basic-typescript/package.json
@@ -21,8 +21,8 @@
     "@types/react": "^17.0.3",
     "@types/react-dom": "^17.0.3",
     "@vitejs/plugin-react": "^2.0.0",
-    "eslint": "7.x",
-    "eslint-config-prettier": "^8.3.0",
+    "eslint": "^8.34.0",
+    "eslint-config-prettier": "^8.8.0",
     "typescript": "^4.2.3",
     "vite": "^3.0.0"
   },

diff --git a/examples/react/basic/.eslintrc b/examples/react/basic/.eslintrc
@@ -1,3 +1,7 @@
 {
-  "extends": ["react-app", "prettier", "plugin:@tanstack/eslint-plugin-query/recommended"]
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended",
+    "plugin:@tanstack/eslint-plugin-query/recommended"
+  ]
 }
diff --git a/examples/react/default-query-function/.eslintrc b/examples/react/default-query-function/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/offline/.eslintrc b/examples/react/offline/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/playground/.eslintrc b/examples/react/playground/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/react-native/package.json b/examples/react/react-native/package.json
@@ -37,12 +37,13 @@
   },
   "devDependencies": {
     "@babel/core": "^7.12.9",
-    "@callstack/eslint-config": "^10.1.0",
+    "@callstack/eslint-config": "^13.0.2",
     "@expo/config": "^3.3.27",
     "@types/react-native": "~0.64.3",
     "babel-plugin-module-resolver": "^4.1.0",
-    "eslint": "^7.32.0",
+    "eslint": "^8.34.0",
     "eslint-import-resolver-alias": "^1.1.2",
+    "eslint-plugin-flowtype": "^8.0.3",
     "eslint-plugin-prettier": "^4.0.0",
     "prettier": "^2.3.2",
     "typescript": "~4.4.3"

diff --git a/examples/react/react-router/.eslintrc b/examples/react/react-router/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/rick-morty/.eslintrc b/examples/react/rick-morty/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/simple/.eslintrc b/examples/react/simple/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/star-wars/.eslintrc b/examples/react/star-wars/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/suspense/.eslintrc b/examples/react/suspense/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/solid/basic-graphql-request/.eslintrc b/examples/solid/basic-graphql-request/.eslintrc
@@ -1,10 +1,5 @@
 {
   "parserOptions": {
-    "project": "./tsconfig.json",
-    "sourceType": "module"
-  },
-  "rules": {
-    "react/react-in-jsx-scope": "off",
-    "jsx-a11y/anchor-is-valid": "off"
+    "project": "./tsconfig.json"
   }
 }
diff --git a/examples/solid/basic-typescript/.eslintrc b/examples/solid/basic-typescript/.eslintrc
@@ -1,10 +1,5 @@
 {
   "parserOptions": {
-    "project": "./tsconfig.json",
-    "sourceType": "module"
-  },
-  "rules": {
-    "react/react-in-jsx-scope": "off",
-    "jsx-a11y/anchor-is-valid": "off"
+    "project": "./tsconfig.json"
   }
 }
diff --git a/examples/solid/default-query-function/.eslintrc b/examples/solid/default-query-function/.eslintrc
@@ -1,10 +1,5 @@
 {
   "parserOptions": {
-    "project": "./tsconfig.json",
-    "sourceType": "module"
-  },
-  "rules": {
-    "react/react-in-jsx-scope": "off",
-    "jsx-a11y/anchor-is-valid": "off"
+    "project": "./tsconfig.json"
   }
 }
diff --git a/examples/solid/simple/.eslintrc b/examples/solid/simple/.eslintrc
@@ -1,11 +1,6 @@
 {
   "extends": ["plugin:@tanstack/eslint-plugin-query/recommended"],
   "parserOptions": {
-    "project": "./tsconfig.json",
-    "sourceType": "module"
-  },
-  "rules": {
-    "react/react-in-jsx-scope": "off",
-    "jsx-a11y/accessible-emoji": "off"
+    "project": "./tsconfig.json"
   }
 }
diff --git a/package.json b/package.json
@@ -65,21 +65,13 @@
     "chalk": "^4.1.2",
     "concurrently": "^7.1.0",
     "current-git-branch": "^1.1.0",
-    "eslint": "7.x",
-    "eslint-config-prettier": "^6.11.0",
-    "eslint-config-react-app": "^5.2.1",
-    "eslint-config-standard": "^14.1.1",
-    "eslint-config-standard-react": "^9.2.0",
-    "eslint-import-resolver-typescript": "^2.7.1",
-    "eslint-plugin-flowtype": "5.x",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jsx-a11y": "6.x",
-    "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^3.1.3",
-    "eslint-plugin-promise": "^4.2.1",
-    "eslint-plugin-react": "7.20.0",
-    "eslint-plugin-react-hooks": "^4.3.0",
-    "eslint-plugin-standard": "^4.0.1",
+    "eslint": "^8.34.0",
+    "eslint-config-prettier": "^8.8.0",
+    "eslint-import-resolver-typescript": "^3.5.5",
+    "eslint-plugin-compat": "^4.1.4",
+    "eslint-plugin-import": "^2.27.5",
+    "eslint-plugin-react": "^7.32.2",
+    "eslint-plugin-react-hooks": "^4.6.0",
     "git-log-parser": "^1.2.0",
     "jest": "^27.5.1",
     "jsonfile": "^6.1.0",

diff --git a/packages/eslint-plugin-query/.eslintrc.cjs b/packages/eslint-plugin-query/.eslintrc.cjs
@@ -1,8 +1,7 @@
 const config = {
-  parser: '@typescript-eslint/parser',
   parserOptions: {
+    tsconfigRootDir: __dirname,
     project: './tsconfig.json',
-    sourceType: 'module',
   },
 }
 

diff --git a/packages/query-async-storage-persister/.eslintrc.cjs b/packages/query-async-storage-persister/.eslintrc.cjs
@@ -1,7 +1,7 @@
 const config = {
   parserOptions: {
+    tsconfigRootDir: __dirname,
     project: './tsconfig.json',
-    sourceType: 'module',
   },
 }
 

diff --git a/packages/query-broadcast-client-experimental/.eslintrc.cjs b/packages/query-broadcast-client-experimental/.eslintrc.cjs
@@ -1,7 +1,7 @@
 const config = {
   parserOptions: {
+    tsconfigRootDir: __dirname,
     project: './tsconfig.json',
-    sourceType: 'module',
   },
 }
 

diff --git a/packages/query-core/.eslintrc.cjs b/packages/query-core/.eslintrc.cjs
@@ -1,7 +1,7 @@
 const config = {
   parserOptions: {
+    tsconfigRootDir: __dirname,
     project: './tsconfig.json',
-    sourceType: 'module',
   },
 }
 

diff --git a/packages/query-persist-client-core/.eslintrc.cjs b/packages/query-persist-client-core/.eslintrc.cjs
@@ -1,7 +1,7 @@
 const config = {
   parserOptions: {
+    tsconfigRootDir: __dirname,
     project: './tsconfig.json',
-    sourceType: 'module',
   },
 }
 

diff --git a/packages/query-sync-storage-persister/.eslintrc.cjs b/packages/query-sync-storage-persister/.eslintrc.cjs
@@ -1,7 +1,7 @@
 const config = {
   parserOptions: {
+    tsconfigRootDir: __dirname,
     project: './tsconfig.json',
-    sourceType: 'module',
   },
 }
 

diff --git a/packages/react-query-devtools/.eslintrc.cjs b/packages/react-query-devtools/.eslintrc.cjs
@@ -1,7 +1,14 @@
 const config = {
+  extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
   parserOptions: {
+    tsconfigRootDir: __dirname,
     project: './tsconfig.json',
-    sourceType: 'module',
+  },
+  rules: {
+    'react/display-name': 'off',
+    'react/jsx-key': ['error', { checkFragmentShorthand: true }],
+    'react/prop-types': 'off',
+    'react-hooks/exhaustive-deps': 'error',
   },
 }