fix(eslint-plugin): ignore internal properties

TanStack · Mar 11, 2023 · 8614233 · 8614233
1 parent b8b0562
commit 8614233
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/eslint-plugin-query/src/rules/exhaustive-deps/exhaustive-deps.test.ts b/packages/eslint-plugin-query/src/rules/exhaustive-deps/exhaustive-deps.test.ts
@@ -247,6 +247,19 @@ ruleTester.run('exhaustive-deps', rule, {
         })
       `,
     },
+    {
+      name: 'should not fail if queryKey does not include an internal dependency',
+      code: normalizeIndent`
+        useQuery({
+          queryKey: ["api"],
+          queryFn: async () => {
+            const response = Promise.resolve([]);
+            const data = await response.json();
+            return data[0].name;
+          },
+        });
+      `,
+    },
   ],
   invalid: [
     {

diff --git a/packages/eslint-plugin-query/src/utils/ast-utils.ts b/packages/eslint-plugin-query/src/utils/ast-utils.ts
@@ -153,7 +153,7 @@ export const ASTUtils = {
     }
 
     const references = scope.references
-      .filter((x) => x.isRead())
+      .filter((x) => x.isRead() && !scope.set.has(x.identifier.name))
       .map((x) => {
         const referenceNode = ASTUtils.traverseUpOnly(x.identifier, [
           AST_NODE_TYPES.MemberExpression,