[Feat] - Display referendum Titles, add react-query #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisling-dev
approved these changes
May 22, 2024
| const referendumData = referendumsData?.find(ref => ref?.referendumIndex === referendum.index) | ||
| return ( | ||
| <Select.Option | ||
| headlineText={referendumData?.title || `Proposal #${referendum.index}`} |
There was a problem hiding this comment.
lets include the proposal number?
Suggested change
| headlineText={referendumData?.title || `Proposal #${referendum.index}`} | |
| headlineText={`#${referendum.index}: ${referendumData?.title}` || `Proposal #${referendum.index}`} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
⛑️ What was done:
Technical:
Note: The API does not support a request with an array of IDs, N requests are required to get the data for each referendum. API calls to unsupported chains are not executed, though they how appear on client side cache as
chainId, { isChainSupported: false }, idType of change
Please delete options that are not relevant.
🧪 How to test:
/voting🖼️ Screenshots:
Screen.Recording.2024-05-20.at.17.18.54.mov
React-query dev tools cache explorer:
If you are new to react-query, the left side is a list of the client side cache. Each item has an unique query key array as an identifier. For this hook the chain name, isChainSupported and the referendum ID are being used for uniqueness and debugging readability.
On the right side the details of a given query is displayed, including the cached data.