fix: disable single signer multisig

TalismanSociety · May 11, 2024 · 822121e · 822121e
1 parent 1f454f9
commit 822121e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/apps/multisig/src/layouts/Settings/SignersSettings.tsx b/apps/multisig/src/layouts/Settings/SignersSettings.tsx
@@ -64,9 +64,10 @@ export const SignersSettings: React.FC<Props> = ({ capHeight, editable, error, m
                 withAddressTooltip
               />
               <Button
+                disabled={!editable}
                 size="icon"
                 variant="ghost"
-                onClick={editable && members.length > 1 ? () => handleRemove(m) : undefined}
+                onClick={members.length > 1 ? () => handleRemove(m) : undefined}
               >
                 <Trash size={16} />
               </Button>

diff --git a/apps/multisig/src/layouts/Settings/ThresholdSettings.tsx b/apps/multisig/src/layouts/Settings/ThresholdSettings.tsx
@@ -13,6 +13,7 @@ type Props = {
 export const ThresholdSettings: React.FC<Props> = ({ disabled, error, membersCount, onChange, threshold }) => {
   useEffect(() => {
     if (threshold > membersCount) onChange(membersCount)
+    else if (threshold < 2 && membersCount > 1) onChange(2)
   }, [membersCount, onChange, threshold])
   return (
     <div css={{ display: 'flex', flexDirection: 'column', gap: 8 }}>

diff --git a/apps/multisig/src/layouts/Settings/index.tsx b/apps/multisig/src/layouts/Settings/index.tsx
@@ -130,7 +130,7 @@ const Settings = () => {
               Reset
             </Button>
             <Button
-              disabled={!changed || apiLoadable.state !== 'hasValue'}
+              disabled={!changed || apiLoadable.state !== 'hasValue' || newMembers.length < 2 || newThreshold < 2}
               loading={changed && apiLoadable.state === 'loading'}
               onClick={handleApplyChanges}
             >