Fix ActiveModel I18n integration #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gix, thanks for the good catch and amazing pull-request! Can you take a look at Travis CI for the spec failures and fix them (it's only rubocop style)? I will merge as soon as the specs are green. |
:i18n_scope is supposed to be a class method. Also, to humanize model names :lookup_ancestors is required (provided by ActiveModel::Translation).
|
Sorry for missing this. I was not aware of rubocop. Pushed a fixed commit. |
|
Don't worry, that's why we run specs on TravisCI. Thanks for your contribution. |
JonathanTron
added a commit
that referenced
this pull request
Dec 18, 2014
Fix ActiveModel I18n integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:i18n_scope is supposed to be a class method. Also, to humanize model names
:lookup_ancestors is required (provided by ActiveModel::Translation).