Fix Sequel::DatabaseConnectionError on db:create:all task #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, running bin/rails db:create:all in a new Rails app with sequel-rails configured to replace ActiveRecord resulted in this error: Sequel::DatabaseConnectionError: PG::ConnectionBad: FATAL: database "rails_app_development" does not exist It then failed to create either the development or test databases. This commit includes db:create:all in the commands checked to enable skip_connect and avoid attempting to connect to the database before it's been created. Previously only db:create was checked. I don't want to make the check too permissive so I'm specifying the full command and still checking the ARGV array of command line arguments. This extends the fix I originally submitted with TalentBox#148.
|
@JonathanTron Actually I'd avoid releasing 1.0.1 until this is reviewed and merged. |
|
@olivierlacan Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, running bin/rails db:create:all in a new Rails
app with sequel-rails configured to replace ActiveRecord resulted in
this error:
Sequel::DatabaseConnectionError: PG::ConnectionBad: FATAL: database "rails_app_development" does not exist
It then failed to create either the development or test databases.
This commit includes db:create:all in the commands checked to enable
skip_connect and avoid attempting to connect to the database before it's
been created.
Previously only db:create was checked. I don't want to make the check
too permissive so I'm specifying the full command and still checking
the ARGV array of command line arguments.
This extends the fix I originally submitted with #148.