Update to Sequel 5.0.0

[Jesterovskiy]

No description provided.

[ckoenig]

Since Sequel 5 immediately attempts to connect to the configured database, the development DB sequel_rails_test_storage_dev needs to be created, too.

Adding the following two lines to .travis.yml will hopefully fix most of the failed tests:

- mysql -e 'create database sequel_rails_test_storage_dev;'
- psql -c 'create database sequel_rails_test_storage_dev;' -U postgres

[ckoenig]

The sqlite3 tests are failing because SequelRails::DbConfig#build_url converts a relative path into an absolute path. Combined with the fact, that Sequel 5 is now eagerly trying to connect to a DB, the test fails.

To fix the test, it might be enough to replace the relative with an absolute path in the Rakefile:

diff --git a/Rakefile b/Rakefile
index 5d991e4..995ab3a 100644
--- a/Rakefile
+++ b/Rakefile
@@ -30,7 +30,7 @@ begin
 
     configs = {
       'postgresql' => { 'TEST_ENCODING' => 'unicode' },
-      'sqlite3'    => { 'TEST_DATABASE' => 'db/database.sqlite3' },
+      'sqlite3'    => { 'TEST_DATABASE' => File.join(File.expand_path("."), "spec/internal/db/database.sqlite3") },
     }

[Jesterovskiy]

@ckoenig Thank you for your help! yesterday I seems to have folded the wrong way =)

[Jesterovskiy]

@JonathanTron @JosephHalter I think PR ready for review =)

[JonathanTron]

@Jesterovskiy Thanks a lot for the amazing work!

I'll take some time to review and merge in the next couple of days.

[bgentry]

LGTM aside from maybe wanting to bump the latest ruby to 2.4.2

[bgentry]

maybe this should be 2.4.2 ?

[bgentry]

probably also 2.4.2 on these

[bgentry]

I don't think we want to lock this in to <= 5.0. Sequel is already on 5.1.0. Possibly < 6.0 instead?

[bgentry]

@Jesterovskiy I opened a PR to fix this specific issue Jesterovskiy#1

[JonathanTron]

Thanks @Jesterovskiy for the good work, I'll merge the request and change the dependencies to deps to work with Sequel < 6.0 as @bgentry suggested.

[Jesterovskiy]

@JonathanTron Thank you! Now you can release this, right?