Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type exports #31

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix type exports #31

merged 1 commit into from
Jul 7, 2023

Conversation

rxw1
Copy link
Contributor

@rxw1 rxw1 commented Jul 7, 2023 •
edited
Loading

Correctly exporting types in package.json. See a similar issue and the solution here for reference: microsoft/TypeScript#52363

Without you get errors like

Could not find a declaration file for module '@tato30/vue-pdf'.
'/home/ok/what/node_modules/@tato30/vue-pdf/dist/index.mjs' implicitly has an 'any' type.
There are types at '/home/ok/what/node_modules/@tato30/vue-pdf/dist/types/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@tato30/vue-pdf' library may need to update its package.json or typings.ts(7016)
⚠ Error (TS7016)

@rxw1
Fix type exports
ae8057e 
Correctly exporting types in package.json. See issue and solution here microsoft/TypeScript#52363 for reference.
@TaTo30 TaTo30 merged commit 9db8435 into TaTo30:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rxw1 @TaTo30