Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Felogin json output is broken with TYPO3 V13 #798

Closed
jawher-tabessi opened this issue Dec 8, 2024 · 2 comments · Fixed by #804
Closed

Felogin json output is broken with TYPO3 V13 #798

jawher-tabessi opened this issue Dec 8, 2024 · 2 comments · Fixed by #804
Assignees
Labels
bug Something isn't working

Comments

@jawher-tabessi
Copy link

jawher-tabessi commented Dec 8, 2024

Describe the bug
Felogin json output is broken with TYPO3 V13

To Reproduce
Steps to reproduce the behavior:

  1. Install a fresh TYPO3 V13 with Headless
  2. Create Felogin form in a page
  3. Show the page
  4. See error : Too few arguments to function TYPO3\CMS\Core\Crypto\HashService::appendHmac(), 1 passed in /var/www/html/vendor/friendsoftypo3/headless/Classes/ViewHelpers/LoginFormViewHelper.php on line 186 and exactly 2 expected

Expected behavior
Proper Felogin json rendering

Screenshots
headless-typo3-v13-felogin

TYPO3 version and TYPO3 Headless version
TYPO3 V13.4.1 / Headless V4.5.0

Additional context
This is caused by this deprecated : https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Deprecation-102763-ExtbaseHashService.html
Possible fix : in LoginFormViewHelper.php line 186 and 190, add additional secret string (timestamp for example) as second argument for appendHmac

@SvenLie
Copy link

SvenLie commented Jan 28, 2025

Could you please create a new release? @lukaszuznanski

@twoldanski
Copy link
Collaborator

@SvenLie if you need this patch asap, you can lock current master as alias 4.5.1 (if your other dependencies do not allow dev-master` on headless extension)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants