Asymmetric Filters Feature #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulbikeimge
added
enhancement
# Conflicts: # backend/sessions/bbbef1d7d0.json # frontend/src/modals/ParticipantDataModal/ParticipantDataModal.tsx # frontend/src/pages/SessionForm/SessionForm.jsx
NCEghtebas
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Really cool new functionality! I also really love the attention to quality of life improvements such as making sure the participant modal opens upon clicking the plus sign in the session creation page and how the default filters are shown in the asymmetric filters view for each participant. Really great workflow design!
I tested it with edge detection, rotation, and openface asymmetric filters + asymmetric canvas with 2 participants with recording and it worked great.
Since this code has some new structural changes I would be grateful if you could quickly update our uml diagram.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR contains the asymmetric filters feature. This feature makes it possible to activate the asymmetric filters for each participant and change the filters through which that participant sees other participants.
How to test?
Create an experiment with at least 2 participants. Navigate to the "Asymmetric Filters" tab within the participant data modal for a participant and enable the asymmetric filters. From the appeared list, apply filters to the other participants for this participant's point of view. Save the session and start the experiment to see the asymmetric filters applied for that participant.
Checklist
development)developmentwas merged into this branch and potential conflicts resolved