Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend Post-Processing #147

Merged
merged 31 commits into from
Jun 11, 2024
Merged

Backend Post-Processing #147

merged 31 commits into from
Jun 11, 2024

Conversation

normaps
Copy link
Collaborator

@normaps normaps commented Sep 30, 2023

Added post-processing section in the connection test page which includes get recording list, check existing subprocess and video post-processing API.

This PR closes #103

@normaps normaps added enhancement New feature or request back end Relating to development tasks in the backend. post-processing Relating to the Post Processign Room or Workflow ater an experiment has been conducted. norma Relating to Norma's Thesis labels Oct 1, 2023
@normaps normaps marked this pull request as draft October 12, 2023 15:38
@normaps normaps added the front end Relating to a development task in the frontend. label Oct 12, 2023
@normaps normaps marked this pull request as ready for review October 30, 2023 08:38
@NCEghtebas NCEghtebas self-requested a review November 10, 2023 05:59
@NCEghtebas
Copy link
Member

👏 Great work!! This completes a mvp of the full experimenter workflow!!

Only suggestion, as discussed, is to change the message handling when a folder is selected and the openface feature extraction fails.

another todo would be to add instructions to set up openface since I now realize that is missing from our project set up. I assigned myself to this issue #190

Copy link
Member

@NCEghtebas NCEghtebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update error handling messages

@NCEghtebas NCEghtebas changed the base branch from main to development November 21, 2023 06:17
@BorderBoy
Copy link
Collaborator

BorderBoy commented Apr 9, 2024

So the post-processing works. But the frontend UI throws some error. See image below
Bildschirmfoto 2024-04-09 um 16 13 33

@NCEghtebas NCEghtebas requested a review from MEnesDeniz June 11, 2024 11:46
@NCEghtebas NCEghtebas force-pushed the backend-np-postprocessing branch from bf67b21 to 6f6ec56 Compare June 11, 2024 12:12
@MEnesDeniz MEnesDeniz merged commit 7e2c64e into development Jun 11, 2024
4 checks passed
@NCEghtebas NCEghtebas deleted the backend-np-postprocessing branch July 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end Relating to development tasks in the backend. enhancement New feature or request front end Relating to a development task in the frontend. norma Relating to Norma's Thesis post-processing Relating to the Post Processign Room or Workflow ater an experiment has been conducted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenFace integration for post processing
4 participants