Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for eth_signTypedData_v4 #16

Closed
alfetopito opened this issue May 13, 2021 · 9 comments
Closed

Add support for eth_signTypedData_v4 #16

alfetopito opened this issue May 13, 2021 · 9 comments

Comments

@alfetopito
Copy link

Any thoughts on adding support for eth_signTypedData_v4?

TokenPocket works perfectly with our app using the dApp browser, but through WalletConnect it fails what a message in the phone app: Not currently supported

Our app uses offline signatures for placing orders.

To reproduce the issue:

  1. Head to https://cowswap.exchange
  2. Connect your wallet using WalletConnect
  3. Pick a token pair and fill in an amount
  4. Enable the sell token
  5. Try to perform a Swap

You can try on Rinkeby and save yourself some gas :)

Platform: Android
Version: 1.2.6
@tararara1111
Copy link

Any thoughts on adding support for eth_signTypedData_v4?

TokenPocket works perfectly with our app using the dApp browser, but through WalletConnect it fails what a message in the phone app: Not currently supported

Our app uses offline signatures for placing orders.

To reproduce the issue:

  1. Head to https://cowswap.exchange
  2. Connect your wallet using WalletConnect
  3. Pick a token pair and fill in an amount
  4. Enable the sell token
  5. Try to perform a Swap

You can try on Rinkeby and save yourself some gas :)

Platform: Android
Version: 1.2.6

@chendatony31
Copy link
Member

Will support in next release.

@chendatony31
Copy link
Member

@alfetopito WalletConnet option seems been removed from cowswap.exchange. Any other site we can test?

@alfetopito
Copy link
Author

alfetopito commented May 17, 2021 •
edited
Loading

@chendatony31 oh, sorry about that.

We have WalletConnect enabled on this dev version https://pr597--gpswapui.review.gnosisdev.com/

See #16 (comment)

@alfetopito alfetopito mentioned this issue May 17, 2021
Merged
4 tasks
@anxolin
Copy link

anxolin commented May 18, 2021

Will support in next release

Great news! 🎉
How often do you release? Is there an ETA for it?

@chendatony31
Copy link
Member

Early June I think @anxolin

This was referenced May 25, 2021
Closed
Merged
@alfetopito
Copy link
Author

Update, the link above will no longer work.
I've created a new on that has TokenPocket enabled via WalletConnect: https://pr674--gpswapui.review.gnosisdev.com/#/swap

@chendatony31
Copy link
Member

Hi, The new version with eth_signTypedData supported has been released. Please try to update @alfetopito @anxolin @tararara1111.

@alfetopito
Copy link
Author

It's working perfectly, thanks a lot!

Just tested on Android version 1.2.8

@anxolin anxolin mentioned this issue Jun 16, 2021
Closed
mergify bot pushed a commit to gnosis/cowswap that referenced this issue Jun 16, 2021
@alfetopito
Re-enable TokenPocket wallet via WalletConnect (#674)
f30e026 
# Update 2021/06/15

TokenPocket has released their update and it's now working flawlessly :)

# Summary

Closes #673 

## Note

I'm opening this PR to allow TP team to test their fix(TP-Lab/tp-android#16), since the wallet was disabled via WalletConnect on #597

# Testing

Using the PR's url:
1. Connect via WalletConnect using TokenPocket wallet
- [ ] The wallet should not be disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alfetopito @chendatony31 @anxolin @tararara1111