Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tbprofiler v5 for structural variants #169

Merged
merged 28 commits into from
Aug 17, 2023

Conversation

abhi18av
Copy link
Member

@abhi18av abhi18av commented Aug 13, 2023

Continuing from #154 (comment)

Added the command line argument for the structural variant results directory. They are not yet added to the summary file, as this requires testing with real data.
@LennertVerboven
Copy link
Collaborator

@abhi18av

So I have completed most of the work on the structural variants workflow and TBProfiler V5. I still need to update the summarize_resistance.py script and will do so as soon as possible. There is currently still an issue with the structural variants as delly is ran on the bam file mapped using the -k 100 parameter which causes delly to miss structural variants. Delly should be run on a sorted, indexed and duplicate marked bam file which is mapped using the default -k parameter

@abhi18av
Copy link
Member Author

@LennertVerboven , I'm doing an integration test on my side now - could you please update the Changelog.md to document the core changes.

In addition, we should include how the new database was generated

@abhi18av
Copy link
Member Author

abhi18av commented Aug 17, 2023

@LennertVerboven ,

The pipeline finished successfully with the new containers and here are some results from the analyses/drug_resistance/combined_variants/resistance_summaries

MTb_L1.SAMN10185847.xlsx
MTb_L3.SAMEA1877181.xlsx
MTb_L43.ERR1193883.xlsx

If these are looking fine, then please merge the PR to develop branch.

@abhi18av abhi18av marked this pull request as ready for review August 17, 2023 10:11
@abhi18av abhi18av self-assigned this Aug 17, 2023
@LennertVerboven LennertVerboven merged commit fa14386 into develop Aug 17, 2023
@abhi18av abhi18av deleted the update_tbprofiler_v5 branch August 18, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants