851 extending target model #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
I broke these tests with the Django restframes update that just got merged in from Dev... |
903 improve target match manager
Fix cone matcher
…faults-to-converttargetextras add option to override defaults to converttargetextras
|
Alpha testing v2.19.0a2 and migrating the MOP TOM system over to use these extended Target models is now complete. Overall the conversion process went very smoothly. In the process I also made extensive use of the new cone search feature to check for duplicated Targets. This was a much more involved process due to MOP-specific data, but that is also now complete, and I think we can accept this story. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a decent sized refactor to give a user the ability to create their own Target Model.
The original
Targetmodel has been replaced by aBaseTargetmodel and moved into a new file calledbase_models.py. TheTargetmodel is then set to be the same asBaseTargetunless a different user model is specified.Docs have been added to explain how a user can extend their target model.