Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

601 alerce query fails with error from tom demo dev #603

Closed
wants to merge 15 commits into from
Closed

601 alerce query fails with error from tom demo dev #603

wants to merge 15 commits into from

Conversation

phycodurus
Copy link
Contributor

Previously saved Broker Queries will still fail and they should be deleted and recreated.

jchate6 and others added 15 commits January 12, 2023 13:33
@jchate6
Create failing test for target name = existing target alias
db8eba4
@jchate6
create a few more failing tests
a2805b3
@jchate6
validate across aliases/target names
d3bec3a
@jchate6
add fuzzy target matching. Break update tests
c3f2207
@jchate6
remove parentheses as well
04b8ae6
@jchate6
fix typo
4c95af4
@jchate6
include aliases in fuzzy match search
dd5421f
@jchate6
add fuzzy matchig to Hermes stream reading
3edfc26
@jchate6
add documentation
1038ab9
@jchate6
make lint happy
3d3f975
@jchate6
Merge branch 'dev' into feature/target_name_resolution
b1e1ea7
@jchate6
Merge pull request #593 from TOMToolkit/feature/target_name_resolution
c10cfd3 
Apply more robust name recognition during target and data ingestion
@jchate6
optimize for fuzzy matching with a prefetch on aliases
782fa84
@phycodurus
value associated with Choice tuple should be 'falsey`
95ec618 
'None' became None b/c 'None' evaluates to true and that
was confounding the list comprehension that filters null
values from the request.
@phycodurus
remove deprecated brokers from Default classes
803cf37
@phycodurus phycodurus linked an issue Feb 2, 2023 that may be closed by this pull request
Alerce query fails with error from tom-demo-dev #601
Open
@phycodurus phycodurus marked this pull request as ready for review February 2, 2023 22:14
rachel3834
rachel3834 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@rachel3834 rachel3834 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good and I think the default options available make sense.

@phycodurus phycodurus changed the base branch from dev to main February 3, 2023 22:49
@phycodurus phycodurus closed this Feb 3, 2023
@phycodurus
Copy link
Contributor Author

This needs to go out now. So, instead of this PR. We'll have a new one that branches from and merges to main (b/c this branched from dev and some of those changes are not ready to go out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel3834 rachel3834 rachel3834 approved these changes

@jchate6 jchate6 Awaiting requested review from jchate6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alerce query fails with error from tom-demo-dev
3 participants
@phycodurus @rachel3834 @jchate6