Feature/generate user data #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Helbig <[email protected]>
Signed-off-by: Kai Helbig <[email protected]>
Signed-off-by: Kai Helbig <[email protected]>
Signed-off-by: Kai Helbig <[email protected]>
Signed-off-by: Kai Helbig <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
space-hawk
reviewed
May 31, 2023
| @@ -27,7 +27,7 @@ | |||
| * <p>Example usage: | |||
| * | |||
| * <pre>{@code | |||
| * TokenConfig config = TokenConfig.aTokenConfig().withSubject("subject).build(); | |||
There was a problem hiding this comment.
I'm not quite sure what you mean. If you're talking about the missing quotation mark: yes, that was broken.
space-hawk
reviewed
May 31, 2023
| @@ -56,12 +55,41 @@ public String getToken( | |||
| .claim("scope", tokenConfig.getScope()) | |||
| .claim("typ", "Bearer") | |||
| .claim("azp", tokenConfig.getAuthorizedParty()); | |||
| Optional<UserData> generatedUserData; | |||
There was a problem hiding this comment.
Hm, yes. But it's not significantly shorter, and the google formatting looks weird:
Optional<UserData> generatedUserData =
tokenConfig.isGenerateUserDataFromSubject() ? Optional.of(
UserData.fromUsernameAndHostname(
tokenConfig.getSubject(), requestConfiguration.getHostname())) : Optional.empty();
space-hawk
approved these changes
May 31, 2023
space-hawk
approved these changes
May 31, 2023
ripssi
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #121 did not see any update for a long time, I decided to implement the desired feature myself.