Flexible device inputs #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devreal
force-pushed
the
flexible-device-inputs
branch
2 times, most recently
from
7ba9d52 to
53959aa
Compare
ttg::device::Input can be filled with buffers and passed to ttg::device::select(). Signed-off-by: Joseph Schuchart <[email protected]>
Set the flow to read-only at the end of the task for flows that are marked as temporary. This allows PaRSEC to put the data into a read-only queue that does not need to be pushed back to the host. Temporary data does not need to be evicted, only released. Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
PaRSEC will try to remove a reader from the resulting read-only flow. Signed-off-by: Joseph Schuchart <[email protected]>
If the flow is only WRITE we don't want to add the READ flag. Signed-off-by: Joseph Schuchart <[email protected]>
Don't return early. Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
Empty buffers are always valid on the current device. Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
This allows querying whether the buffer is current on the given device. Also add a note that Buffer::current_device() cannot reflect the fact that all devices may have the current data (e.g., after a pushout). Also add static ttg::device::Device::host() that returns the host device. Signed-off-by: Joseph Schuchart <[email protected]>
Missing register_device_memory on span and Buffer::empty Signed-off-by: Joseph Schuchart <[email protected]>
…ncludes Signed-off-by: Joseph Schuchart <[email protected]>
devreal
force-pushed
the
flexible-device-inputs
branch
from
87d6b36 to
b932ac0
Compare
The code path for no-arg callables was missing a return and we have to specify template arguments for std::array explicitly because the array could be empty. Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
abouteiller
approved these changes
Dec 12, 2024
therault
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next set of changes needed for MRA. This change set allows buffers to be empty and const and enables tasks to define a flexible set of device inputs using
ttg::device::Input, which is a vector of buffers internals provided by the backend implementation.