Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor checking logs: expand results if empty #11126

Closed
damithc opened this issue May 11, 2021 · 7 comments · Fixed by #11151
Closed

Instructor checking logs: expand results if empty #11126

damithc opened this issue May 11, 2021 · 7 comments · Fixed by #11151
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.

Comments

@damithc
Copy link
Contributor

damithc commented May 11, 2021

Scenario: instructor searches for logs using the /web/instructor/logs page.

Current: all results panels are collapsed by default.
Suggested: If there are no results for some sessions, we can expand them automatically so that the user doesn't have to click to find out.

image

We can also consider expanding all results panels by default? Are there any downsides?
@damithc damithc added a-UIX User Interface, User eXperience, responsiveness p.VeryLow Just cosmetic value only. Do only if we have spare resources. labels May 11, 2021
@damithc
Copy link
Contributor Author

damithc commented May 11, 2021

Audit-logs team, is this one suitable for first-timers?

@t-cheepeng
Copy link
Contributor

Yes, it is suitable for first-timers

@t-cheepeng t-cheepeng added the good first issue Easy; restricted for first-time contributors label May 12, 2021
@mgutierrez98
Copy link

Is this being handled by anyone currently?

@moziliar
Copy link
Contributor

@Maezzzzz as far as we know, no one is at it. You can attempt to submit PR for this issue.

@hoonti06
Copy link
Contributor

I am a beginner. I want to work on this.

@moziliar
Copy link
Contributor

@hoonti06 thank you for your interest in this issue.

As @Maezzzzz has not confirmed commitment on this issue, @hoonti06 you can try to submit an PR.

@hoonti06
Copy link
Contributor

@moziliar Thank you!

@hoonti06 hoonti06 mentioned this issue May 24, 2021
Merged
rrtheonlyone added a commit that referenced this issue Jun 5, 2021
@hoonti06 @madanalogy @rrtheonlyone
[#11126] Expand empty search results for feedback session logs (#11151)
1123653 
* Modify isTabExpanded initialization

* Modified that if expand button does not exist and only collapse button exists, the session is skipped

* Modified that if there is no panel expand button, the session is skipped

* Modified that click the expand button only when it exists

* Modified that get the session name from the element with class name 'card-header'

Co-authored-by: Ahmed Bahajjaj <[email protected]>
Co-authored-by: Rahul Rajesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#11126] Expand empty search results for feedback session logs hoonti06/teammates
5 participants
@damithc @hoonti06 @moziliar @t-cheepeng @mgutierrez98