This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257
Reference #242 (comment)
success
of type booleanImplementors
@jiyoontbd @kirahsapong @diehuxx (please tag anyone else in the comment section if appropriate)
Two things.
First,
Close
is now valid after any message type. I believe in some implementations we have a function akin toisValidNext()
which inspects the message type (& its contents?) and determines if the given message is valid as the next message in the exchange. In places where we do have this code, we'll need to ensure it allowsClose
messages at any point.Second, add a new property
Close.success
which is an optional boolean. Ensure thatsuccess
is accessible during creation/validation/parsing/etc (wherever appropriate).