Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Add Close.success to the protocol spec #286

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

KendallWeihe
Copy link
Contributor

Closes #257

Reference #242 (comment)

  1. Close messages are valid after any message type
  2. Close message introduces a new optional property success of type boolean

Implementors

@jiyoontbd @kirahsapong @diehuxx (please tag anyone else in the comment section if appropriate)

Two things.

First, Close is now valid after any message type. I believe in some implementations we have a function akin to isValidNext() which inspects the message type (& its contents?) and determines if the given message is valid as the next message in the exchange. In places where we do have this code, we'll need to ensure it allows Close messages at any point.

Second, add a new property Close.success which is an optional boolean. Ensure that success is accessible during creation/validation/parsing/etc (wherever appropriate).

Copy link
Contributor

@jiyoonie9 jiyoonie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KendallWeihe KendallWeihe merged commit 94eeec4 into main Mar 24, 2024
@KendallWeihe KendallWeihe deleted the kendallw/257-close-success branch March 24, 2024 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rules for Close messages
4 participants