Issue 58: Unable to re-arrange the submission workflow in Manage Workflow. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow. The organization is being changed but the dirty flag is not being set. Manually set the dirty flag before sending. The `OrganizationRepo` listeners are either not doing anything or they are not checking for when status is a failure. The `ApiResponseActions.READ` and `ApiResponseActions.BROADCAST` never do anything because the `resetManageOrganization()` only does anything when the organization is provided. No organization is being provided.
…t does something. The `OrganizationRepo.listen(ApiResponseActions.READ,...` call was removed for being a no-op. Even older code suggests that this should in fact be doing something. Add the function call back, but this time add the selected organization if one exists so that the function is not a no-op. Whether or not this change fixes or breaks something is unclear. Be wary of regressions. Be hopeful of bonus bug fixes.
jsavell
approved these changes
Apr 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #58
The organization is being changed but the dirty flag is not being set. Manually set the dirty flag before sending.
The
OrganizationRepolisteners are either not doing anything or they are not checking for when status is a failure.The
ApiResponseActions.READandApiResponseActions.BROADCASTnever do anything because theresetManageOrganization()only does anything when the organization is provided.No organization is being provided.
Edit:
The
OrganizationRepo.listen(ApiResponseActions.READ, function (res) {has been added back with an additional change that makes the function do something rather than being a no-op functon. The organization, if one is selected, is now set. It is unclear if this change fixes a bug or if this change causes a regression. Neither a regression nor a bug fix was observed while doing some basic testing.The
BROADCASTlistener remains removed.