Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JXL "Speed" clarification #749

Closed
kremzli opened this issue Feb 7, 2024 · 8 comments
Closed

JXL "Speed" clarification #749

kremzli opened this issue Feb 7, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@kremzli
Copy link

kremzli commented Feb 7, 2024

Is your feature request related to a problem? Please describe.
I dont understand what "Speed" slider means under Effort, lower effort would mean faster, and how do you make it faster and have it try harder at the same time? I also tested it with JXL Lossy, speed 1 and 4 compressed better than speed 2, i dont think thats right?

Describe the solution you'd like
Explaining my question

Describe alternatives you've considered
None

@kremzli kremzli added the enhancement New feature or request label Feb 7, 2024
@T8RIN
Copy link
Owner

T8RIN commented Feb 7, 2024

Idk, it's comes from jxl-coder

@T8RIN T8RIN closed this as completed Feb 7, 2024
@kremzli
Copy link
Author

kremzli commented Mar 11, 2024

awxkee/jxl-coder#14 it is for decoding speed, specifying that would be much more clear

@T8RIN
Copy link
Owner

T8RIN commented Mar 11, 2024

He just said to refer to libjxl specifications, if you would find this explanation, i will add this info ofc 👀

@T8RIN T8RIN reopened this Mar 11, 2024
@kremzli
Copy link
Author

kremzli commented Mar 11, 2024

Well i cant find it but i know its just for decoding speed (useful for large images, but even those are already fast), and as with my original comment, it is a known bug in libjxl that speed 1 and 4 compress better than 2. Adding decoding speed shouldnt be necessary and left to the user as it would add a bit more size to the image

@kremzli
Copy link
Author

kremzli commented Mar 11, 2024

So maybe make it by default 0 and specify that it will make the image a bit bigger, also how mostly unnecessary it is but people hopefully would know that already

@T8RIN
Copy link
Owner

T8RIN commented Mar 11, 2024

Okay, somewhat understood

@kremzli
Copy link
Author

kremzli commented Mar 11, 2024

It can also affect quality for lossy

T8RIN added a commit that referenced this issue Mar 11, 2024
@T8RIN T8RIN closed this as completed Mar 11, 2024
@kremzli
Copy link
Author

kremzli commented Mar 12, 2024

It does not affect quality for lossy. I was just reading the help command from libjxl, what it means is higher file sizes for the same quality, that translates to lower quality at the same file sizes.
I asked on the discord for some clarification, heres what i got:
There is no documentation on what libjxl's faster decoding flag does internally. "faster decoding just disables various stuff that will cause decoding to be slower, sacrificing some compression for faster decoding. Should generally not be needed for most use cases."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants