Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GECKO 3.1.1 #340

Merged
merged 37 commits into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
8000996
fix: getStandardKcat with multiple subSystems
edkerk Apr 2, 2023
db4258f
Merge pull request #299 from SysBioChalmers/fix/standardKcat
edkerk Apr 3, 2023
189e7fa
Bug: Fix compatibility running ecFSEOF with GECKO3 models (#301)
ae-tafur May 11, 2023
ba7cb9e
feat: user defined proteins to ignore in tunning kcats (#306)
ae-tafur May 12, 2023
575594a
fix: applyCustomKcats with customKcats structure input (#304)
edkerk May 12, 2023
53313b7
doc: updateProtPool and flexibilizeProtConcs (#297)
edkerk May 15, 2023
0621aa2
feat: a function that creates a the project structure an adapter clas…
ae-tafur May 17, 2023
148a434
feat: currencyMets and pseudoreactions handling (#313)
edkerk May 17, 2023
26acf71
chore: restructure tutorials (#310)
mihai-sysbio May 31, 2023
2c1984d
feat: add manually-generated doc for online use
mihai-sysbio Jun 20, 2023
71b6d4e
Merge branch 'develop' into feat/online-docs
mihai-sysbio Jun 20, 2023
42afd22
feat: updateGECKOdoc function
edkerk Jun 20, 2023
9e85e10
chore: update documentation
edkerk Jun 20, 2023
6313fd7
Merge pull request #318 from SysBioChalmers/feat/online-docs
mihai-sysbio Jun 21, 2023
02b5810
fix: getStandardKcat and applyKcatConstraints (#320)
edkerk Jun 22, 2023
0e9ab29
fix: minor bugs identified (#316)
ae-tafur Jun 25, 2023
c30c7a7
feat: updates related to tutorials (#319)
edkerk Jun 26, 2023
adfc216
fix: full_ecModel tutorial ecFVA (#321)
edkerk Jun 29, 2023
a3a9154
refactor: applyComplexData (#323)
edkerk Jun 29, 2023
9135940
feat: light_ecModel tutorial getSubsetEcModel (#322)
edkerk Jun 30, 2023
900e2b7
feat: parameters format, phylDist.mat file and yeast-GEM.yml (#325)
edkerk Jun 30, 2023
c11d730
docs: add link to tutorials in README
mihai-sysbio Jun 30, 2023
7dedda9
docs: skip mentioning the required RAVEN version, since it is checked…
mihai-sysbio Jun 30, 2023
38b6768
Merge pull request #326 from SysBioChalmers/docs/minor-readme-improve…
mihai-sysbio Jun 30, 2023
5fef1fa
feat: compare light vs full ecModel (#328)
edkerk Jul 3, 2023
5137fc6
chore: rerun light_ecModel tutorial (#331)
edkerk Jul 3, 2023
b0fc364
docs: uncomment to run DLKcat
mihai-sysbio Jul 5, 2023
1eca793
docs: suggestions for full tutorial protocol
mihai-sysbio Jul 5, 2023
15ecc6d
doc: in response to comments in PR
edkerk Jul 5, 2023
edfb5b7
Merge pull request #335 from SysBioChalmers/docs/polishing
mihai-sysbio Jul 6, 2023
b4ee971
feat: flexEnz instead of flexProt + more detailed errors (#336)
edkerk Jul 10, 2023
cfa4c46
feat: Add new rxns to ecModel & fix: ecFSEOF (#337)
ae-tafur Jul 15, 2023
8931176
refactor: rename ProtConcs to EnzConcs (#339)
edkerk Jul 15, 2023
910ff1a
fix: remove old figure files
edkerk Jul 15, 2023
c0837e3
Merge tag 'v3.1.0' into develop
edkerk Jul 15, 2023
856872c
doc: clarify PR merge strategies in contrib guide (#341)
edkerk Jul 16, 2023
f29852a
Fix: get flux target at different alphas (#342)
ae-tafur Jul 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ The following points should be considered when merging branches to `develop`:

* Make sure the branch gets accepted by at least one developer with writing access.
* Wait at least a day before merging, to allow other developers to inspect the pull request.
* To simplify the git history, use "Squash and merge" in pull requests to `develop` (but **never** use this option when merging to `main`, see also below).
* As soon as the branch is merged, confirm that `develop` is still possible to merge to `main` (this can be checked [here](https://github.com/SysBioChalmers/GECKO/compare/develop)). If conflicts appear, fix the conflict _locally_ as soon as possible in `develop` and then push it (note, **DO NOT** pull any other changes from `main` to `develop`, just the single file that is creating the conflict).

### Releasing a new version
Expand All @@ -169,8 +170,9 @@ When releasing, please follow these steps:
- Specify the intended version in the title, e.g. `GECKO 3.0.1`
- Indicating all new features/fixes/etc. and referencing every previous pull request included (examples [here](https://github.com/SysBioChalmers/GECKO/releases)).
- If any [issue](https://github.com/SysBioChalmers/GECKO/issues) gets solved in the release, write in the pull request description "Closes #X", where "X" is the issue number. That way the issue will be automatically closed after merge.
2. Wait at least a day for at least one approval. The GitHub Actions must also pass successfully.
3. Merge the pull request from `develop` to `main`.
4. Make the [new release](https://github.com/SysBioChalmers/GECKO/releases/new) at GitHub:
2. Wait at least a day for at least one approval. The GitHub Actions must also pass successfully.
3. Merge the pull request from `develop` to `main` with the option "Create a merge commit", **not** "Squash and merge".
4. Edit the `version.txt` in the `main` branch directly [link](https://github.com/SysBioChalmers/GECKO/edit/main/version.txt) to refer to the new version number. Commit the change directly to the `main` branch.
5. Make the [new release](https://github.com/SysBioChalmers/GECKO/releases/new) at GitHub:
- Define a new tag with the version, prefixed by `v`: e.g. `v3.0.1`.
- Copy the description from the corresponding PR from step 1.
20 changes: 12 additions & 8 deletions .github/ISSUE_TEMPLATE/bug-detected.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: Bug detected
about: GECKO is not working as it should...
about: Report a bug if GECKO was functioning as it should.
title: Bug detected
labels: bug
assignees: ''
Expand All @@ -13,18 +13,22 @@ assignees: ''
- What have you tried yourself to fix it? -->

#### Reproducing these results:
<!-- If applicable, please attach the problematic code. -->
<!-- If applicable, please attach the problematic code. This
is very useful for us to replicate the problem you encountered. -->
```matlab
% If you worked on matlab, paste your code here
```

#### System information
<!-- Please report details of the system where you encountered the bug. -->
* Operating system: <!-- (Windows/Mac/Linux; include version) -->
* Operating system: <!-- Windows/Mac/Linux; include version -->
* MATLAB version: <!-- E.g. 2022b -->
* GECKO version: <!-- If you did not use the latest GECKO version, have you tried to update and encountered the same problem? -->
* GECKO version: <!-- Have you tried the latest GECKO version? -->
* RAVEN version: <!-- Output from checkInstallation -->
* Solver: <!-- Gurobi (include version) / glpk / cobra / etc. -->

**I hereby confirm that I have:**
- [ ] Tested my code with [all requirements](https://github.com/SysBioChalmers/GECKO) for running GECKO
- [ ] Done this analysis in the `main` branch of the repository
- [ ] Checked that a similar issue does not exist already
#### I hereby confirm that:
<!-- Replace [ ] with [X] to check the box:-->
- [ ] My GECKO installation met [all requirements](https://github.com/SysBioChalmers/GECKO#required-software).
- [ ] This bug occurs in the `main` branch of the repository.
- [ ] A similar [issue](https://github.com/SysBioChalmers/GECKO/issues) does not already exist.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ blank_issues_enabled: true
contact_links:
- name: Gitter Channel
url: https://gitter.im/SysBioChalmers/GECKO
about: Please ask and answer questions here.
about: You may also ask questions (or contribute with answers) at the GECKO Gitter channel.
10 changes: 5 additions & 5 deletions .github/ISSUE_TEMPLATE/new-feature.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
---
name: New feature
about: You would like GECKO to do something it does not yet do.
about: You can propose a new or modified features if you would like GECKO to do something it is not yet able to do.
title: New feature
labels: enhancement
assignees: ''

---

### Description of the new feature:
Expand All @@ -14,6 +13,7 @@ assignees: ''
- Do you have an idea on how to implement this feature?
- Will you implement this feature yourself (in that case, you can Assign yourself in the top right corner) or need help with this? We will gladly support you in this! -->

**I hereby confirm that I have:**
- [ ] Done this analysis in the `main` branch of the repository
- [ ] Checked that a similar issue does not exist already
#### I hereby confirm that:
<!-- Replace [ ] with [X] to check the box:-->
- [ ] The new feature is not already in the `main` branch of the repository.
- [ ] A similar [issue](https://github.com/SysBioChalmers/GECKO/issues) does not already exist.
17 changes: 11 additions & 6 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
### Main improvements in this PR:
<!-- Pointwise mention what changes were made in what function. Examples:
- fix bug where `functionName` failed to do function X
- updated all documentation
- resolves issue #12345 -->
- Fixes:
- `functionName` failed to do function X
- Documentation:
- updated all documentation
- Features:
- Introduced option to do function Y (issue #12345) -->

**I hereby confirm that I have:**
<!-- Note: replace [ ] with [X] to check the box -->
- [ ] Selected `develop` as a target branch (top left drop-down menu)
#### Instructions on merging this PR:
<!-- Chose ONE of the following two options
and replace [ ] with [X] to check the box.-->
- [ ] This PR has `develop` as target branch, and will be resolved with a *squash-merge*.
- [ ] This PR has `main` as target branch, and will be resolved with a *merge commit*.
Loading