Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getStandardKcat with multiple subSystems #299

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Apr 2, 2023

Main improvements in this PR:

  • fix:
    • getStandardKcat handling models that have multiple subSystems assigned to the same reaction.

I hereby confirm that I have:

  • Selected develop as a target branch (top left drop-down menu)

@edkerk edkerk requested a review from ae-tafur April 2, 2023 20:47
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
Running geckoCoreFunctionTests
Model-specific DLKcat input stored at /home/m/actions-runner/_work/GECKO/GECKO/test/unit_tests/ecTestGEM/data/DLKcat_input_test.tsv
Limit has been reached. Protein P5 seems to be problematic. Consider changing the kcat.
Done geckoCoreFunctionTests
__________

Note: In the case of multiple test runs, this post will be edited.

@mihai-sysbio
Copy link
Member

The output of the action looks unexpected, but also doesn't seem to be caused by changes in this PR. Should it be investigated further (perhaps as a separate issue)?

Model-specific DLKcat input stored at /home/m/actions-runner/_work/GECKO/GECKO/test/unit_tests/ecTestGEM/data/DLKcat_input_test.tsv
Limit has been reached. Protein P5 seems to be problematic. Consider changing the kcat.

@ae-tafur
Copy link
Collaborator

ae-tafur commented Apr 3, 2023

The output of the action looks unexpected, but also doesn't seem to be caused by changes in this PR. Should it be investigated further (perhaps as a separate issue)?

Model-specific DLKcat input stored at /home/m/actions-runner/_work/GECKO/GECKO/test/unit_tests/ecTestGEM/data/DLKcat_input_test.tsv
Limit has been reached. Protein P5 seems to be problematic. Consider changing the kcat.

I think is ok, this is output from the functions tested. runDLKcat (not 100% sure), and flexibilizeProtConcs (when a limit is set)

@mihai-sysbio
Copy link
Member

Other recent PRs have a much more verbose output when running the test suite, e.g. #295 (comment) . Perhaps I missed something, but I was expecting a similar output here.

@ae-tafur
Copy link
Collaborator

ae-tafur commented Apr 3, 2023

Other recent PRs have a much more verbose output when running the test suite, e.g. #295 (comment) . Perhaps I missed something, but I was expecting a similar output here.

Yeap, that was because a test was failing (check more here), but due to RAVEN reversibility assignment. This was fixed here

@edkerk edkerk merged commit db4258f into develop Apr 3, 2023
@edkerk edkerk deleted the fix/standardKcat branch April 3, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants