add slither analysis github action #484
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## This PR is blocked until crytic/slither#919 is resolved (slither doesn't still support custom errors).No longer blocked after https://github.com/crytic/slither/releases/tag/0.8.2Tasks:
slither-local
command insynthetix-main
works (should print analysis results in terminal).slither-sarif
command insynthetix-main
works (should create asarif
format file).core-contracts
&core-modules
and not onlysynthetix-main
sub packages.