Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slither analysis github action #484

Closed
wants to merge 2 commits into from
Closed

add slither analysis github action #484

wants to merge 2 commits into from

Conversation

artdgn
Copy link

@artdgn artdgn commented Nov 29, 2021

## This PR is blocked until crytic/slither#919 is resolved (slither doesn't still support custom errors). No longer blocked after https://github.com/crytic/slither/releases/tag/0.8.2

Tasks:

  • Ensure slither-local command in synthetix-main works (should print analysis results in terminal).
  • Ensure slither-sarif command in synthetix-main works (should create a sarif format file).
  • Ensure the sarif file is picked up in PRs and pushes and the analysis is shown in PRs diffs and "checks" tabs.
  • Add slither analysis for core-contracts & core-modules and not only synthetix-main sub packages.
  • Look into the released github-action https://github.com/marketplace/actions/slither-action

@artdgn artdgn changed the title [blocked] add slither analysis github action add slither analysis github action Dec 15, 2021
@artdgn artdgn marked this pull request as draft December 15, 2021 00:07
@artdgn artdgn force-pushed the add-slither-action branch from a769fd9 to ac8671d Compare February 7, 2022 03:11
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #484 (cbfad1b) into main (5f6b998) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          71       71           
  Lines        1233     1233           
  Branches       62       62           
=======================================
  Hits         1198     1198           
  Misses         35       35           
Flag Coverage Δ
core-contracts 100.00% <ø> (ø)
core-js 99.25% <ø> (ø)
core-modules 100.00% <ø> (ø)
deployer 96.34% <ø> (ø)
synthetix-main 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6b998...cbfad1b. Read the comment docs.

@artdgn
Copy link
Author

artdgn commented Feb 7, 2022

Updated the PR with latest main.

It seems that slither is having difficulties:

I guess worth to wait for resolutions of the errors on slither side.

@dbeal-eth
Copy link
Contributor

I believe we have decided we don't want slither.

@dbeal-eth dbeal-eth closed this Nov 2, 2022
@mjlescano mjlescano deleted the add-slither-action branch February 3, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants