Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SABnzbd to 3.6.0 #5307

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Update SABnzbd to 3.6.0 #5307

merged 3 commits into from
Jun 15, 2022

Conversation

Safihre
Copy link
Contributor

@Safihre Safihre commented Jun 9, 2022

Update SABnzbd to 3.6.0.

I also limited the size of the cross/p7zip dependency, which is only used by SABnzbd.

@Safihre Safihre requested review from th0ma7 and hgy59 June 9, 2022 07:46
- build 7za only (the default target)
- avoid definition of duplicate flags
- avoid build of shared libraries (prevent build of executable in lib/p7zip and creation of links in bin folder)
@hgy59
Copy link
Contributor

hgy59 commented Jun 10, 2022

@Safihre was sabnzbd ever able to use 7za that could not be found in the path?

@Safihre
Copy link
Contributor Author

Safihre commented Jun 14, 2022

@Safihre was sabnzbd ever able to use 7za that could not be found in the path?

It was always able to find it, somehow it was in the PATH.

@Safihre
Copy link
Contributor Author

Safihre commented Jun 15, 2022

Ah, before it found:

2022-04-29 09:55:10,867::INFO::[SABnzbd:471] 7za binary... found (/bin/7z)

Now it finds:

2022-06-15 13:27:48,704::INFO::[SABnzbd:471] 7za binary... found (/volume1/@appstore/sabnzbd/bin/7za)

Thanks @hgy59

@Safihre Safihre merged commit fed9f03 into SynoCommunity:master Jun 15, 2022
@Safihre
Copy link
Contributor Author

Safihre commented Jun 15, 2022

@th0ma7 For some reason the build fails on cryptography, even though it worked yesterday.
I can't figure out why.. do you see the difference?
Today: https://github.com/SynoCommunity/spksrc/actions/runs/2501879929
Yesterday: https://github.com/Safihre/spksrc/actions/runs/2474706131

@Safihre
Copy link
Contributor Author

Safihre commented Jun 15, 2022

Right, the problem is in setuptools==62.4.0, which is installed by get-pip. See the changelog: https://github.com/pypa/setuptools/blob/main/CHANGES.rst

Strange, because after get-pip we install the old setuptools.. So seems it's keeping some old leftovers?

@Safihre
Copy link
Contributor Author

Safihre commented Jun 16, 2022

@th0ma7 Seems we made a mistake, the get-pip.py "pip==21.3.1" is not how you can call the script, it always installs the latest pip.
However, it does have the ability to supply --no-setuptools --no-wheel parameters:
Safihre@c734828

But, it still doesn't work 😢
https://github.com/Safihre/spksrc/runs/6919748449?check_suite_focus=true

Seems maybe the problem is this latest pip version..

@th0ma7
Copy link
Contributor

th0ma7 commented Jun 16, 2022

If I recall the only pip being installed as "latest" is at package installation time.
At build time I'll have to investigate a little more as all versions are fixed in cross/python310 and native/python310.
I'll run a few tests while playing with deluge PR to find out.

@th0ma7
Copy link
Contributor

th0ma7 commented Jun 16, 2022

If I recall the only pip being installed as "latest" is at package installation time. At build time I'll have to investigate a little more as all versions are fixed in cross/python310 and native/python310. I'll run a few tests while playing with deluge PR to find out.

EDIT: And btw, setuptools==62.4.0 was tested against all crossenv wheels before merging... perhaps the issue is elsewhere.

@Safihre
Copy link
Contributor Author

Safihre commented Jun 17, 2022

If I recall the only pip being installed as "latest" is at package installation time. At build time I'll have to investigate a little more as all versions are fixed in cross/python310 and native/python310. I'll run a few tests while playing with deluge PR to find out.

No, that's not what happens. Check the build logs and it can be seen in the content of get-pip.py. It controls which version is installed, and is regularly updated: https://bootstrap.pypa.io/get-pip.py

If we want to control exact the pip version, we should use python -m ensurepip and install the bundled old version and then update it to our specified that version.

I think we should also really apply my patch for setuptools and wheel: Safihre@c734828

But it all still doesn't fix cryptography.. If I rerun my exact old build that once succeeded (so not a single line of code changed) it now fails.. So something changed upstream.

Original build (success): https://github.com/Safihre/spksrc/actions/runs/2474706131/attempts/1
Attempt 2 of same commit (failure): https://github.com/Safihre/spksrc/actions/runs/2474706131/attempts/2

@Safihre
Copy link
Contributor Author

Safihre commented Jun 17, 2022

Ok, fixed it!

AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
* Only the 7za binary is relevant for p7zip

* Update SABnzbd to 3.6.0

* adjust cross/p7zip

- build 7za only (the default target)
- avoid definition of duplicate flags
- avoid build of shared libraries (prevent build of executable in lib/p7zip and creation of links in bin folder)

Co-authored-by: hgy59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants